Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.11] Adapt Start Stop TS to Windows #79

Merged
merged 5 commits into from
May 11, 2021

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented May 5, 2021

Backport of #75.
Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904

@Sgitario
Copy link
Contributor Author

Sgitario commented May 5, 2021

@rsvoboda I guess it's fine to skip the Native build in 1.11 as it's not a requirement for QUARKUS-874.

@Sgitario Sgitario requested a review from rsvoboda May 5, 2021 06:12
@Sgitario Sgitario changed the title Adapt Start Stop TS to Windows [1.11] Adapt Start Stop TS to Windows May 5, 2021
@Sgitario
Copy link
Contributor Author

@rsvoboda I've found some issues when running in Windows. Will let you know once these issues are fixed.

@Sgitario
Copy link
Contributor Author

PR updated with the following changes:

  • The wrong mvnw command was being used in Windows. Changed the static field by static method worked fine.
  • Fix Graphql whitelisted log. There was a missing dot at the end.
  • Disable SSL verification to use HTTPs URLs for the code starter

These changes must be backported to main and that's why I didn't squash them. However, it needs first to be verified as part of the Github CI and Jenkins CI.

Backport of quarkus-qe#75.
Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904
@rsvoboda rsvoboda merged commit e735d79 into quarkus-qe:1.11 May 11, 2021
@Sgitario Sgitario mentioned this pull request May 11, 2021
@Sgitario Sgitario deleted the windows_1_11 branch May 12, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants