Configure Github CI to run tests on Windows #75

Sgitario · 2021-04-22T08:44:10Z

Changes:

Windows fails to stop an application when running on DEV mode. Reported issue: Quarkus is not gratefully being shutdown in Windows when running in DEV mode quarkusio/quarkus#14647
Windows disallows to delete folders when they are being used by the file explorer or the processes are about to be exited. This is why:

I'm ignoring these errors when the directory can't be deleted (it's not Quarkus issue)
I splitted the "s p a c e s" runs into there different folders for jvm, native and dev mode.

Sgitario · 2021-04-23T13:12:32Z

1.11.X is not working on Native in Windows due to quarkusio/quarkus#7990. Therefore, we need to upgrade to 1.13.X to make Windows work on Native: #76

Sgitario · 2021-04-28T08:20:35Z

testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java

    @Test
    public void spacesJVM(TestInfo testInfo) throws IOException, InterruptedException {
-        testRuntime(testInfo, Apps.JAX_RS_MINIMAL, MvnCmds.JVM, "s p a c e s");
+        testRuntime(testInfo, Apps.JAX_RS_MINIMAL, MvnCmds.JVM, "s p a c e s j v m");


Explanation about this change in PR description

Sgitario · 2021-04-28T08:20:38Z

testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java

-            if (appDestDir.exists()) {
-                FileUtils.deleteDirectory(appDestDir);
-            }
+            removeDirWithSpecialCharacters(appDestDir);


Explanation about this change in PR description

Sgitario · 2021-04-28T08:20:43Z

testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java

    }

    @Test
    public void spacesDEV(TestInfo testInfo) throws IOException, InterruptedException {
-        testRuntime(testInfo, Apps.JAX_RS_MINIMAL, MvnCmds.DEV, "s p a c e s");
+        testRuntime(testInfo, Apps.JAX_RS_MINIMAL, MvnCmds.DEV, "s p a c e s d e v");


Explanation about this change in PR description

Sgitario · 2021-04-28T08:20:47Z

testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java

    }

    @Test
    @Tag("native")
    public void spacesNative(TestInfo testInfo) throws IOException, InterruptedException {
-        testRuntime(testInfo, Apps.JAX_RS_MINIMAL, MvnCmds.NATIVE, "s p a c e s");
+        testRuntime(testInfo, Apps.JAX_RS_MINIMAL, MvnCmds.NATIVE, "s p a c e s n a t i v e");


Explanation about this change in PR description

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java

.github/workflows/ci.yaml

testsuite/src/it/java/io/quarkus/ts/startstop/utils/Logs.java

rsvoboda · 2021-04-28T10:58:48Z

testsuite/src/it/java/io/quarkus/ts/startstop/utils/Logs.java

+            }
+
+            for (Pattern ignoredLine : ignoredLines) {
+                offendingLines.removeIf(line -> ignoredLine.matcher(line).matches());


No auditing what gets skipped

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java

rsvoboda · 2021-04-28T11:06:35Z

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java

+            Pattern.compile(".*Uber JAR strategy is used for native image source JAR generation on Windows.*"),
+            Pattern.compile(".*Duplicate entry about.html entry.*"),
+            Pattern.compile(".*Dependencies with duplicate files detected.*"),
+            Pattern.compile(".*objcopy executable not found in PATH. Debug symbols will not be separated from executable.*"),


We have the same issue handled a bit differently - https://github.com/quarkus-qe/quarkus-startstop/blob/main/testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java#L88

TBH I'm not sure if we need to handle special WINDOWS_COMMON / WINDOWS_DEV_MODE_ERRORS / WINDOWS_NATIVE.
I would just go with the platformErrs approach, merge ^^^ into one array

Sgitario · 2021-04-28T11:24:50Z

PR updated with the following changes:

Move Windows whitelisted errors into the existing platformErrs approach
Not to ignore SLF4J errors. If this happens again with Windows, it will fail.

I will mark all the comments as resolved once I'm happy with the new changes and the CI passes.

Sgitario · 2021-04-28T12:38:09Z

@rsvoboda would you mind to take another look? I moved the windows errors to platform windows errors, but kept the ones about dev console as this is an issue that should be removed once solved.
About the slf4j errors, this is not whitelisted any longer, so if it happens again, the test will fail as expected.

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java

Sgitario · 2021-04-28T12:54:11Z

PR updated to move some shared constants between Windows and Mac.

Sgitario · 2021-04-29T04:58:35Z

I've updated the PR to whitelist the "unable to create directory for vert.x cache" error only for Windows. This is reported by quarkusio/quarkus#16895.

Changes: - Windows fails to stop an application when running on DEV mode. Reported issue: quarkusio/quarkus#14647 - Windows disallows to delete folders when they are being used by the file explorer or the processes are about to be exited. This is why: 1. I'm ignoring these errors when the directory can't be deleted (it's not Quarkus issue) 2. I splitted the "s p a c e s" runs into there different folders for jvm, native and dev mode.

Backport of quarkus-qe#75. Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904

Backport of #75. Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904

Sgitario force-pushed the support-windows branch 3 times, most recently from 7e41318 to 72b1fc1 Compare April 22, 2021 09:21

Sgitario mentioned this pull request Apr 22, 2021

Configure check for Windows #53

Closed

Sgitario force-pushed the support-windows branch 7 times, most recently from 7a902be to 0be3168 Compare April 23, 2021 10:03

Sgitario force-pushed the support-windows branch 7 times, most recently from 67569d4 to 7a68c8c Compare April 28, 2021 07:56

Sgitario commented Apr 28, 2021

View reviewed changes

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java Outdated Show resolved Hide resolved

Sgitario requested a review from rsvoboda April 28, 2021 08:28

Sgitario marked this pull request as ready for review April 28, 2021 08:28

rsvoboda requested changes Apr 28, 2021

View reviewed changes

Sgitario force-pushed the support-windows branch from 7a68c8c to 7133090 Compare April 28, 2021 11:22

Sgitario force-pushed the support-windows branch from 7133090 to bf55f8e Compare April 28, 2021 11:54

Sgitario requested a review from rsvoboda April 28, 2021 12:37

rsvoboda requested changes Apr 28, 2021

View reviewed changes

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java Outdated Show resolved Hide resolved

testsuite/src/it/java/io/quarkus/ts/startstop/utils/WhitelistLogLines.java Outdated Show resolved Hide resolved

Sgitario force-pushed the support-windows branch from bf55f8e to 74dc39a Compare April 28, 2021 12:52

Sgitario requested a review from rsvoboda April 28, 2021 12:54

Sgitario force-pushed the support-windows branch from 1af6f26 to b66cbe9 Compare April 29, 2021 04:57

Sgitario force-pushed the support-windows branch from b66cbe9 to 0321a88 Compare April 29, 2021 06:03

rsvoboda approved these changes Apr 29, 2021

View reviewed changes

rsvoboda merged commit 9bc32ea into quarkus-qe:main Apr 29, 2021

Sgitario deleted the support-windows branch April 29, 2021 07:31

Sgitario added a commit to Sgitario/quarkus-startstop that referenced this pull request May 5, 2021

Adapt Start Stop TS to Windows

23f77ba

Backport of quarkus-qe#75. Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904

Sgitario mentioned this pull request May 5, 2021

[1.11] Adapt Start Stop TS to Windows #79

Merged

Sgitario added a commit to Sgitario/quarkus-startstop that referenced this pull request May 10, 2021

Adapt Start Stop TS to Windows

1493b26

Backport of quarkus-qe#75. Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904

rsvoboda pushed a commit that referenced this pull request May 11, 2021

Adapt Start Stop TS to Windows

0f9c3bb

Backport of #75. Won't run Native as it's not working on 1.11 due to quarkusio/quarkus#14904

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure Github CI to run tests on Windows #75

Configure Github CI to run tests on Windows #75

Sgitario commented Apr 22, 2021 •

edited

Loading

Sgitario commented Apr 23, 2021

Sgitario Apr 28, 2021

Sgitario Apr 28, 2021

Sgitario Apr 28, 2021

Sgitario Apr 28, 2021

rsvoboda Apr 28, 2021

rsvoboda Apr 28, 2021

Sgitario commented Apr 28, 2021 •

edited

Loading

Sgitario commented Apr 28, 2021

Sgitario commented Apr 28, 2021

Sgitario commented Apr 29, 2021

Configure Github CI to run tests on Windows #75

Configure Github CI to run tests on Windows #75

Conversation

Sgitario commented Apr 22, 2021 • edited Loading

Sgitario commented Apr 23, 2021

Sgitario Apr 28, 2021

Choose a reason for hiding this comment

Sgitario Apr 28, 2021

Choose a reason for hiding this comment

Sgitario Apr 28, 2021

Choose a reason for hiding this comment

Sgitario Apr 28, 2021

Choose a reason for hiding this comment

rsvoboda Apr 28, 2021

Choose a reason for hiding this comment

rsvoboda Apr 28, 2021

Choose a reason for hiding this comment

Sgitario commented Apr 28, 2021 • edited Loading

Sgitario commented Apr 28, 2021

Sgitario commented Apr 28, 2021

Sgitario commented Apr 29, 2021

Sgitario commented Apr 22, 2021 •

edited

Loading

Sgitario commented Apr 28, 2021 •

edited

Loading