Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Upgrade to Quarkus 1.13.2.Final #266

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Upgrade to Quarkus 1.13.2.Final #266

merged 2 commits into from
Apr 23, 2021

Conversation

Sgitario
Copy link
Contributor

Changes:

  • Remove workaround of issues/14525
  • Changed TODO by comment for issues/15464
  • Make sure we use the same gRPC port for running in prod and test (for backward compatibility)

@Sgitario Sgitario requested a review from rsvoboda April 16, 2021 09:00
This was referenced Apr 16, 2021
Closed
Merged
Closed
Closed
@Sgitario
Copy link
Contributor Author

run tests

@Sgitario
Copy link
Contributor Author

@rsvoboda JVM worked fine, the failures are caused by timeout due to download the artifacts in OpenShift is slow.
I think we're good to merge this PR now.

@Sgitario
Copy link
Contributor Author

run tests

@Sgitario
Upgrade to Quarkus 1.13.2.Final
18310d2 
Changes:
- Remove workaround of issues/14525
- Changed TODO by comment for issues/15464
- Make sure we use the same gRPC port for running in prod and test (for backward compatibility)
@Sgitario
Copy link
Contributor Author

I've updated the external applications modules to increase the timeout to build these apps to 20 minutes.

@Sgitario
Copy link
Contributor Author

run tests

@rsvoboda
Copy link
Member

CI is not green yet, @Sgitario can you provide tl;dr what's wrong?

@Sgitario
Copy link
Contributor Author

There are some sneaky tests here and there. Now, it failed the kafka avro tests, in other runs, the amqp reactive failed. Everything looks good when running the tests locally.
I fixed the tests about external applications by increasing the timeout to build.
From my point of view, this PR is ready to be merged.

@rsvoboda
Copy link
Member

So merge and stabilize as we go?

@Sgitario
Copy link
Contributor Author

So merge and stabilize as we go?

From my point of view, yes. Those failures are not related to Quarkus 1.13.2.Final since have failed in the past too.

rsvoboda
rsvoboda approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for "merge now and stabilise as we go" approach

@rsvoboda rsvoboda merged commit ad61546 into quarkus-qe:main Apr 23, 2021
@Sgitario Sgitario deleted the upgrade_quarkus branch April 23, 2021 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sgitario @rsvoboda