This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
Added lifecycle application module #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsvoboda
approved these changes
Mar 16, 2021
...ication/src/test/java/io/quarkus/ts/openshift/lifecycle/LifecycleApplicationOpenShiftIT.java
Outdated
Show resolved
Hide resolved
...ication/src/test/java/io/quarkus/ts/openshift/lifecycle/LifecycleApplicationOpenShiftIT.java
Outdated
Show resolved
Hide resolved
rsvoboda
reviewed
Mar 16, 2021
...ication/src/test/java/io/quarkus/ts/openshift/lifecycle/LifecycleApplicationOpenShiftIT.java
Outdated
Show resolved
Hide resolved
rsvoboda
suggested changes
Mar 16, 2021
...ication/src/test/java/io/quarkus/ts/openshift/lifecycle/LifecycleApplicationOpenShiftIT.java
Outdated
Show resolved
Hide resolved
...ication/src/test/java/io/quarkus/ts/openshift/lifecycle/LifecycleApplicationOpenShiftIT.java
Outdated
Show resolved
Hide resolved
...ication/src/test/java/io/quarkus/ts/openshift/lifecycle/LifecycleApplicationOpenShiftIT.java
Show resolved
Hide resolved
|
@rsvoboda , I think I've already addressed your comments. Also, I've created a new assertion to validate expected arguments. Note that I've commented this verification out as I could not find any property to do this. |
|
Added "DO NOT MERGE" label to state that this is not working for upstream issues that will be addressed soon. |
|
QUARKUS-866 has been fixed in upstream, but this PR remains blocked because of quarkusio/quarkus#15953 |
|
pls rebase |
Done |
|
Depends on #266 |
|
Rebased and verified that is correctly working on OCP. |
rsvoboda
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic coverage for https://issues.redhat.com/browse/QUARKUS-866.
Note that this module is not working due to the above issue.
I still need to either disable some tests or add the workaround.