Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RouteConstants for Vert.x web route order marks #588

Merged
merged 2 commits into from
Dec 14, 2023
Merged

RouteConstants for Vert.x web route order marks #588

merged 2 commits into from
Dec 14, 2023

Conversation

shivarm
Copy link
Member

@shivarm shivarm commented Dec 11, 2023 •
edited by melloware
Loading

Use RouteConstants for Vert.x web route order marks and Upgrade Quarkus 3.6.x

Fixes Issue

Fix #587

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@melloware melloware requested a review from ia3andy December 11, 2023 15:03
@melloware melloware added the bug Something isn't working label Dec 11, 2023
@melloware melloware added this to the 2.3.0 milestone Dec 11, 2023
@melloware
Copy link
Contributor

LGTM assigned to @ia3andy for review. I marked this 2.3.0 since this bumps Quarkus version.

ia3andy
ia3andy requested changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivam-sharma7, I 've just asked for a change in the Quarkus version

pom.xml Show resolved Hide resolved
@melloware melloware merged commit 5367e0f into quarkiverse:main Dec 14, 2023
2 checks passed
@shivarm shivarm deleted the RouteConstants branch December 14, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

@ia3andy ia3andy ia3andy requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Upgrade Quarkus 3.2.x to 3.6.x
3 participants
@shivarm @melloware @ia3andy