Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Quarkus 3.2.x to 3.6.x #587

Closed
shivam-sharma7 opened this issue Dec 11, 2023 Discussed in #586 · 1 comment · Fixed by #588
Closed

Upgrade Quarkus 3.2.x to 3.6.x #587

shivam-sharma7 opened this issue Dec 11, 2023 Discussed in #586 · 1 comment · Fixed by #588
Assignees
Labels
bug Something isn't working
Milestone

Comments

@shivam-sharma7
Copy link
Member

Discussed in #586

Originally posted by shivam-sharma7 December 11, 2023
I have seen the error throw by the CI, look at: https://github.com/quarkiverse/quarkus-quinoa/actions/runs/6961577600/job/18943475183#step:8:2047 and this is not allow to upgrade of quarkus 3.6.x

and I used quinoa QUINOA_ROUTE_ORDER as DEFAULT_ROUTE_ORDER and that fixed the above problem and CI passed, look at: https://github.com/shivam-sharma7/quarkus-quinoa/actions/runs/7163520949/job/19502083461

before

import static io.quarkus.vertx.http.runtime.VertxHttpRecorder.DEFAULT_ROUTE_ORDER;

import java.io.IOException;
import java.util.List;
import java.util.Set;
import java.util.function.Supplier;

import org.jboss.logging.Logger;

import io.quarkus.runtime.annotations.Recorder;
import io.vertx.core.Handler;
import io.vertx.core.Vertx;
import io.vertx.core.http.HttpHeaders;
import io.vertx.core.http.HttpMethod;
import io.vertx.core.http.impl.MimeMapping;
import io.vertx.ext.web.RoutingContext;

@Recorder
public class QuinoaRecorder {
    private static final Logger LOG = Logger.getLogger(QuinoaRecorder.class);
    public static final String META_INF_WEB_UI = "META-INF/webui";
    public static final int QUINOA_ROUTE_ORDER = 1100;
    public static final int QUINOA_SPA_ROUTE_ORDER = DEFAULT_ROUTE_ORDER + 30_000;
    public static final Set<HttpMethod> HANDLED_METHODS = Set.of(HttpMethod.HEAD, HttpMethod.OPTIONS, HttpMethod.GET);

    public Handler<RoutingContext> quinoaProxyDevHandler(final QuinoaHandlerConfig handlerConfig, Supplier<Vertx> vertx,
            String host, int port, boolean websocket) {
        logIgnoredPathPrefixes(handlerConfig.ignoredPathPrefixes);
        return new QuinoaDevProxyHandler(handlerConfig, vertx.get(), host, port, websocket);
    }

after

import java.io.IOException;
import java.util.List;
import java.util.Set;
import java.util.function.Supplier;

import org.jboss.logging.Logger;

import io.quarkus.runtime.annotations.Recorder;
import io.vertx.core.Handler;
import io.vertx.core.Vertx;
import io.vertx.core.http.HttpHeaders;
import io.vertx.core.http.HttpMethod;
import io.vertx.core.http.impl.MimeMapping;
import io.vertx.ext.web.RoutingContext;

@Recorder
public class QuinoaRecorder {
    private static final Logger LOG = Logger.getLogger(QuinoaRecorder.class);
    public static final String META_INF_WEB_UI = "META-INF/webui";
    public static final int QUINOA_ROUTE_ORDER = 1100;
    public static final int DEFAULT_ROUTE_ORDER = QUINOA_ROUTE_ORDER;
    public static final int QUINOA_SPA_ROUTE_ORDER = DEFAULT_ROUTE_ORDER + 30_000;
    public static final Set<HttpMethod> HANDLED_METHODS = Set.of(HttpMethod.HEAD, HttpMethod.OPTIONS, HttpMethod.GET);

    public Handler<RoutingContext> quinoaProxyDevHandler(final QuinoaHandlerConfig handlerConfig, Supplier<Vertx> vertx,
            String host, int port, boolean websocket) {
        logIgnoredPathPrefixes(handlerConfig.ignoredPathPrefixes);
        return new QuinoaDevProxyHandler(handlerConfig, vertx.get(), host, port, websocket);
    }
@melloware melloware added the bug Something isn't working label Dec 11, 2023
@melloware
Copy link
Contributor

Found the issue that broke it: quarkusio/quarkus#35917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants