Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow zero sized registers in QROMs and PRGAViaPhaseGradient #1160

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Disallow zero sized registers in QROMs and PRGAViaPhaseGradient #1160

merged 3 commits into from
Jul 20, 2024

Conversation

tanujkhattar
Copy link
Collaborator

Unblocks #1105

@tanujkhattar tanujkhattar requested a review from mpharrigan July 19, 2024 00:51
@tanujkhattar tanujkhattar changed the title Disallow zero sized registers in QROM and PRGAViaPhaseGradient Disallow zero sized registers in QROMs and PRGAViaPhaseGradient Jul 19, 2024
mpharrigan
mpharrigan approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeeeeet

@tanujkhattar tanujkhattar enabled auto-merge (squash) July 20, 2024 01:19
@tanujkhattar tanujkhattar merged commit 41e9f2e into quantumlib:main Jul 20, 2024
7 checks passed
@tanujkhattar tanujkhattar mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

Assignees

@mpharrigan mpharrigan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanujkhattar @mpharrigan