Make the pypirc generation script safer #6410
Conversation
* avoid accidental modification of user's pypirc, instead have the script output config without changing any file * use absolute path in the shebang * drop unnecessary triple quotes. In bash they just concatenate an empty string. * fail script early if required environment variables do not exist
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6410 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1111 1111
Lines 97088 97088
==========================================
- Hits 94965 94964 -1
- Misses 2123 2124 +1 ☔ View full report in Codecov by Sentry. |
|
@pavoljuhas wiil this work and not get a permission denied |
strange, let me check this. converting to a draft for few test commits... |
|
@pavoljuhas I also have this draft #6409. which one do you think we should go with? |
#6409 looks good, let us go with that one. |
I see - the permission denied was happening for the main branch at ea6fabc, #6409 is also a good solution so let us stick with that one. |
….yml" This reverts commit 4d00579.
|
Superseded by #6409 |
avoid accidental modification of user's pypirc, instead
have the script output new config without changing any file.
use absolute path in the shebang.
drop unnecessary triple quotes.
In bash they just concatenate an empty string.
fail script early if required environment variables do not exist.