Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from bash to template approach for creating pypi config file #6409

Merged
merged 7 commits into from
Jan 10, 2024
Merged

switch from bash to template approach for creating pypi config file #6409

merged 7 commits into from
Jan 10, 2024

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Jan 10, 2024 •
edited
Loading

this is to resolve the permission denied issue

@NoureldinYosri NoureldinYosri marked this pull request as ready for review January 10, 2024 17:19
@NoureldinYosri NoureldinYosri requested review from vtomole, cduck and a team as code owners January 10, 2024 17:19
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8f7ed7) 97.81% compared to head (ee06199) 97.81%.
Report is 1 commits behind head on main.

❗ Current head ee06199 differs from pull request most recent head b154b3f. Consider uploading reports for the commit b154b3f to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6409   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files        1111     1111           
  Lines       97088    97088           
=======================================
  Hits        94965    94965           
  Misses       2123     2123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoureldinYosri NoureldinYosri marked this pull request as draft January 10, 2024 18:33
@NoureldinYosri NoureldinYosri mentioned this pull request Jan 10, 2024
Closed
pavoljuhas
pavoljuhas approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the last commit onto main so we have only new changes in the PR.

Otherwise LGTM with a tiny nit.

@NoureldinYosri NoureldinYosri marked this pull request as ready for review January 10, 2024 18:58
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) January 10, 2024 18:58
@NoureldinYosri NoureldinYosri merged commit 4d35768 into main Jan 10, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoureldinYosri @pavoljuhas