Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen networkx requirements #6105

Merged
merged 5 commits into from
May 24, 2023
Merged

Loosen networkx requirements #6105

merged 5 commits into from
May 24, 2023

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented May 23, 2023

Fixes #6047

@vtomole vtomole changed the title Teating: Update requirements: support networkx 3.0 Testing: Update requirements: support networkx 3.0 May 23, 2023
@CirqBot CirqBot added the Size: XS <10 lines changed label May 23, 2023
@vtomole vtomole closed this May 24, 2023
@vtomole vtomole deleted the vtomole-patch-2 branch May 24, 2023 19:21
@vtomole vtomole restored the vtomole-patch-2 branch May 24, 2023 20:29
@vtomole vtomole reopened this May 24, 2023
@vtomole vtomole changed the title Testing: Update requirements: support networkx 3.0 Loosen networkx requirements May 24, 2023
@vtomole vtomole marked this pull request as ready for review May 24, 2023 21:41
@vtomole vtomole requested review from a team and cduck as code owners May 24, 2023 21:42
@vtomole vtomole requested review from pavoljuhas and mpharrigan May 24, 2023 21:42
@@ -5,7 +5,7 @@ backports.cached_property~=1.0.1; python_version < '3.8'

duet~=0.2.8
matplotlib~=3.0
networkx~=2.4
networkx>=2.4 # can't do networkx>=3.0 until https://github.com/rigetti/pyquil/issues/1553 is fixed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly I don't think this is worth mentioning. Until there is a networkx 3 feature that we actually want to use it's a good thing that we support both :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@vtomole vtomole requested a review from mpharrigan May 24, 2023 23:21
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @vtomole ! sorry for the confusion

@mpharrigan mpharrigan enabled auto-merge (squash) May 24, 2023 23:24
@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 24, 2023
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 24, 2023
@mpharrigan mpharrigan merged commit 16ed00d into master May 24, 2023
@vtomole vtomole deleted the vtomole-patch-2 branch August 30, 2023 20:08
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
* Update requirements.txt

* Update requirements.txt

* Update requirements.txt

* Update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update requirements: support networkx 3.0
3 participants