-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements: support networkx 3.0 #6047
Comments
Does anyone know why this restriction is in place? git blame is not helpful. @cqc-melf did you try manually installing networkx and seeing if any of the tests break? |
Looks like we have a conflict with pyquil
|
surely this shouldn't affect |
It should not. I would guess we only pinned it to pass our CI/CDs. Will test locally. |
Just confirmed that |
Thank you for taking a look! I have not run any tests, if there is something I can do to help you, please let me know! |
Not sure if you have seen this, I have already reported a similar problem to pyquil |
We can update |
What does "deploy" mean here? I'd imagine we'd want to ship |
Our code base works with both networkx 2 and 3 but our checks don't work with |
We don't have a CI check that tests |
Looks like loosening the requirements to |
The actual problem is that the pinned networkx version in |
@cqc-melf Please let us know if this version of cirq-core fixes your issue. |
Thank you all for the update! I will try this in the next days! |
Description of the issue
You are currently using the old
networkx~=2.4
version in thecirq-core
python package. Would it be possible for you to upgrade tonetworkx~=3.0
?See file
cirq-core/requirements.txt
Cirq version
1.1.0
The text was updated successfully, but these errors were encountered: