Make _create_transformer_with_kwargs a public method #5492
Conversation
tanujkhattar
requested review from
dabacon,
ColemanCollins,
nakardo,
gmauricio,
a team,
vtomole,
cduck,
wcourtney and
verult
as code owners
cirq-core/cirq/transformers/target_gatesets/compilation_target_gateset.py
Show resolved
Hide resolved
cirq-core/cirq/transformers/target_gatesets/compilation_target_gateset.py
Show resolved
Hide resolved
| circuit: 'cirq.AbstractCircuit', *, context: Optional['cirq.TransformerContext'] = None | ||
| ) -> 'cirq.AbstractCircuit': | ||
| return func(circuit, context=context, **kwargs) # type: ignore | ||
| return transformer(circuit, context=context, **kwargs) # type: ignore |
There was a problem hiding this comment.
Why do we need the type ignore? I guess it's because cirq.TRANSFORMER is a callable protocol whose __call__ signature does not allow for extra kwargs. Might we be able to remove the type ignore by extending the signature with explicit kwargs?
In any case, there should be a comment explaining the reason for the ignore and linking to a mypy issue if there is one open.
There was a problem hiding this comment.
I guess it's because cirq.TRANSFORMER is a callable protocol whose call signature does not allow for extra kwargs.
Yes, that's right.
Might we be able to remove the type ignore by extending the signature with explicit kwargs?
This is not possible because function arguments are contravariant, so adding **kwargs to the signature of the protocol would mean that every transformer would need to support a **kwargs : Any; which is bad.
In any case, there should be a comment explaining the reason for the ignore and linking to a mypy issue if there is one open.
Added a comment.
cirq-core/cirq/transformers/target_gatesets/compilation_target_gateset.py
Show resolved
Hide resolved
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)'] |
CirqBot
removed
automerge
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
Fixes #5491