Move CircuitDag to contrib #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves CircuitDag to contrib. - cirq.CircuitDag is now deprecated and now must be changed to cirq.contrib.CircuitDag. - Also moves the related cirq.Unique class Note: the tests use a high number of cirq.Unique instances which are also moved, so unable to verify count of deprecation messages in many tests.
dstrain115
added
the
BREAKING CHANGE
MichaelBroughton
approved these changes
Jun 10, 2022
|
|
||
| from cirq.contrib.acquaintance.executor import AcquaintanceOperation, ExecutionStrategy | ||
| from cirq.contrib.acquaintance.mutation_utils import expose_acquaintance_gates | ||
| from cirq.contrib.acquaintance.permutation import LogicalIndex, LogicalMapping | ||
| from cirq.contrib.circuitdag import CircuitDag |
There was a problem hiding this comment.
Nit: prefer module import
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from cirq.contrib.circuitdag.circuit_dag import CircuitDag, Unique |
There was a problem hiding this comment.
Why do we need our own circuitdag folder ?
There was a problem hiding this comment.
It's used in 3 different sub modules - contrib/acquaintance; contrib/routing; contrib/paulistring
So, I think it makes sense to make a separate submodule / folder for circuit dag. Note that all code is in specific submodules in contrib/* and we don't have any top-level python files in contrib, so we shouldn't put circuitdag as a top level python file directly in contrib/.
There was a problem hiding this comment.
Yeah, this was to stay consistent with other modules in contrib.
| @@ -15,6 +15,7 @@ | |||
| from typing import cast | |||
|
|
|||
| from cirq import circuits, ops, protocols | |||
| from cirq.contrib.circuitdag import CircuitDag | |||
There was a problem hiding this comment.
Nit: module import
| @@ -15,10 +15,11 @@ | |||
| import networkx | |||
|
|
|||
| from cirq import circuits, linalg | |||
| from cirq.contrib.circuitdag import CircuitDag | |||
There was a problem hiding this comment.
Nit: module import
| @@ -15,7 +15,7 @@ | |||
| from typing import Any, Callable, Iterable, Sequence, Tuple, Union, cast, List | |||
|
|
|||
| from cirq import circuits, ops, protocols | |||
|
|
|||
| from cirq.contrib.circuitdag import CircuitDag, Unique | |||
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| from cirq import circuits, ops, value | |||
| import cirq.contrib.acquaintance as cca | |||
| from cirq.contrib.circuitdag import CircuitDag | |||
There was a problem hiding this comment.
Nit: module import
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Move CircuitDag to contrib - Moves CircuitDag to contrib. - cirq.CircuitDag is now deprecated and now must be changed to cirq.contrib.CircuitDag. - Also moves the related cirq.Unique class Note: the tests use a high number of cirq.Unique instances which are also moved, so unable to verify count of deprecation messages in many tests.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Move CircuitDag to contrib - Moves CircuitDag to contrib. - cirq.CircuitDag is now deprecated and now must be changed to cirq.contrib.CircuitDag. - Also moves the related cirq.Unique class Note: the tests use a high number of cirq.Unique instances which are also moved, so unable to verify count of deprecation messages in many tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to cirq.contrib.CircuitDag.
Note: the tests use a high number of cirq.Unique instances which
are also moved, so unable to verify count of deprecation messages
in many tests.
Fixes: #3816