Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is anyone using CircuitDag? #3816

Closed
mpharrigan opened this issue Feb 17, 2021 · 3 comments · Fixed by #5481
Closed

Is anyone using CircuitDag? #3816

mpharrigan opened this issue Feb 17, 2021 · 3 comments · Fixed by #5481
Assignees
Labels
area/circuits kind/design-issue A conversation around design triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@mpharrigan
Copy link
Collaborator

I did some digging, since I've never personally used CircuitDag. I see it was added here #759 in response to this feature request: #547. Searching for usages turns up some utility in cirq.contrib.routing. Otherwise, my reading of these issues and some personal intuition is that this class was originally a "solution looking for a problem". Even in the case with of #3599, we found out that CircuitDag was close but not what we wanted.

One way of moving forward with #3599 is to extend CircuitDag to do what we need for factorizing circuits, but I think we'd need a better set of use cases.

Another proposal is to deprecate CircuitDag from main cirq prior to 1.0, move the functionality to cirq.contrib.routing and wait on a full design for the time at which we add routing to main-cirq

cc @bryano @cduck @Strilanc

@mpharrigan mpharrigan added the kind/design-issue A conversation around design label Feb 17, 2021
@balopat balopat added the triage/discuss Needs decision / discussion, bring these up during Cirq Cynque label Feb 17, 2021
@balopat
Copy link
Contributor

balopat commented Feb 24, 2021

Cirq Cynque verdict: deprecate nicely into contrib, where it will fall into the "archive" category eventually as we dismantle contrib.

@viathor viathor added area/circuits triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Mar 16, 2021
@dstrain115
Copy link
Collaborator

@tanujkhattar What is the action item here? Should we deprecate CircuitDag?

@tanujkhattar
Copy link
Collaborator

+1, let's deprecate and move to contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/circuits kind/design-issue A conversation around design triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants