Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce less idiomatic code for _group_interchangeable_qubits implementation #5273

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Apr 20, 2022

Fixes: #5148
Reverts: #4941

I'm willing to hear about making this code idiomatic while not breaking the newly added test.

@vtomole vtomole requested review from a team and cduck as code owners April 20, 2022 16:47
@vtomole vtomole requested a review from viathor April 20, 2022 16:47
@CirqBot CirqBot added the size: S 10< lines changed <50 label Apr 20, 2022
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, then LGTM. IMO this is no less "idiomatic" than the code being reverted :-)

cirq-core/cirq/ops/gate_operation.py Outdated Show resolved Hide resolved
@vtomole vtomole merged commit 36d09c1 into master Apr 20, 2022
@vtomole vtomole deleted the revert_idiomatic branch April 20, 2022 20:11
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Apr 22, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New implementation of _group_interchangeable_qubits can create duplicate keys in returned Tuple
3 participants