Use group_interchangeable_qubits for qubit comparison in GateOperation #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n._equal_up_to_global_phase
cirq-core/cirq/ops/gate_operation.py
Outdated
Comment on lines
152
to
158
| return tuple( | ||
| (k, frozenset(g for _, g in kg)) | ||
| for k, kg in itertools.groupby( | ||
| enumerate(self.qubits), | ||
| lambda i_q: cast( | ||
| gate_features.InterchangeableQubitsGate, self.gate | ||
| ).qubit_index_to_equivalence_group_key(i_q[0]), |
There was a problem hiding this comment.
Could we break this up into a few simpler lines ? This is a little hard to read.
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
quantumlib#4941) Fix for issue quantumlib#4766 Also, Introduced more idiomatic code for group_interchangeable_qubits implementation.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
quantumlib#4941) Fix for issue quantumlib#4766 Also, Introduced more idiomatic code for group_interchangeable_qubits implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4766
Also, Introduced more idiomatic code for group_interchangeable_qubits implementation.