Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ion and neutral_atoms packages under devices #4269

Closed
wants to merge 5 commits into from
Closed

Move ion and neutral_atoms packages under devices #4269

wants to merge 5 commits into from

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jun 28, 2021 •
edited
Loading

Move ion and neutral_atoms packages under cirq.devices.

Fixes #2793.
Part of #3228 and #3245.

@balopat balopat requested review from cduck, HGSilveri, vtomole and a team as code owners June 28, 2021 21:23
@balopat balopat requested a review from dstrain115 June 28, 2021 21:23
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 28, 2021
HGSilveri
HGSilveri approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for the part concerning Pasqal!

@balopat
Copy link
Contributor Author

balopat commented Jun 30, 2021

Okay for the part concerning Pasqal!

Thanks @HGSilveri!

@CirqBot CirqBot added size: XL lines changed >1000 size: M 50< lines changed <250 and removed size: XL lines changed >1000 labels Aug 12, 2021
@dabacon
Copy link
Collaborator

dabacon commented Apr 6, 2022

The new plan is to move these out to the vendors that use them. Closing.

@dabacon dabacon closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGSilveri HGSilveri HGSilveri approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees

@dstrain115 dstrain115

Labels
cla: yes Makes googlebot stop complaining. size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: move ion and neutral into devices
5 participants
@balopat @dabacon @HGSilveri @dstrain115 @CirqBot