Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move ion and neutral into devices #2793

Closed
dabacon opened this issue Feb 26, 2020 · 4 comments · Fixed by #5563
Closed

Proposal: move ion and neutral into devices #2793

dabacon opened this issue Feb 26, 2020 · 4 comments · Fixed by #5563
Assignees
Labels
area/devices area/packages kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@dabacon
Copy link
Collaborator

dabacon commented Feb 26, 2020

Currently ion and neutral, which are devices plus decomposition methods sit at the top level of cirq and get imported into the cirq.* namespace. Having these as top level modules is a bit odd since they are really about a particular device (and gates). I suggest that we move the files in these directories into the devices module (or maybe subdirectories of devices?)

I think they are generic enough that we can keep them at the cirq.* namespace, (aqt relies on them as does the coming pasqal).

The question then comes up about the device in aqt. But aqt is an api, so I think having api's in submodules cirq.aqt and cirq.google which also have devices is a good encapsulation.

@dabacon
Copy link
Collaborator Author

dabacon commented May 8, 2020

Alternative: create separate module which contains them (architectures)?

@balopat
Copy link
Contributor

balopat commented Sep 1, 2020

This is part of #3228. I believe that we should do this.

@balopat balopat added kind/health For CI/testing/release process/refactoring/technical debt items and removed kind/feature-request Describes new functionality labels Sep 1, 2020
@MichaelBroughton
Copy link
Collaborator

xref #5130 , #5128

@dstrain115
Copy link
Collaborator

Discussion from cirq cync: Let's move neutral atoms into Pasqal, let's either move IonDevice into ionq (or delete it). Reason is that neither is used by more than one package. cirq-core will have a stronger deprecation policy so let's put them into vendor packages, so that, if needed, they can be a feature add rather than a later deletion.

CirqBot pushed a commit that referenced this issue Jun 14, 2022
@tanujkhattar tanujkhattar self-assigned this Jun 14, 2022
augustehirth pushed a commit to augustehirth/Cirq that referenced this issue Jun 15, 2022
CirqBot pushed a commit that referenced this issue Jun 21, 2022
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devices area/packages kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
5 participants