Skip to content

Commit

Permalink
[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/…
Browse files Browse the repository at this point in the history
…v1' - Mandatory for K8s 1.16 (helm#20892)

* [incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16

Signed-off-by: Jacky Jiang <[email protected]>

* As of Kubernetes 1.8, you must specify a pod selector that matches the labels of the .spec.template.
This fix the issue with creating DaemonSet through new `apps/v1` api.

Signed-off-by: Jacky Jiang <[email protected]>
  • Loading branch information
t83714 authored and Ian Levesque committed Jul 13, 2020
1 parent 91f363d commit 8497201
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion incubator/kube-registry-proxy/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: kube-registry-proxy
home: https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/registry
version: 0.3.1
version: 0.3.2
appVersion: 0.4
description: Installs the kubernetes-registry-proxy cluster addon.
maintainers:
Expand Down
5 changes: 4 additions & 1 deletion incubator/kube-registry-proxy/templates/daemon.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: {{ template "kube-registry-proxy.fullname" . }}
Expand All @@ -7,6 +7,9 @@ metadata:
release: {{ .Release.Name | quote }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
spec:
selector:
matchLabels:
app: {{ template "kube-registry-proxy.fullname" . }}
template:
metadata:
name: {{ template "kube-registry-proxy.fullname" . }}
Expand Down

0 comments on commit 8497201

Please sign in to comment.