[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 #20892

t83714 · 2020-02-19T23:56:34Z

What this PR does / why we need it:

There are several deprecations in the API introduced in K8s 1.16 (see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#deprecations-and-removals) which affect our manifests.

This PR changes [incubator/kube-registry-proxy] DaemonSet apiVersion to apps/v1.
Also, as of Kubernetes 1.8, you must specify a pod selector that matches the labels of the .spec.template(see here).
This PR also adds proper selector value to [incubator/kube-registry-proxy] DaemonSet.

Checklist

DCO signed
Chart Version bumped
Variables are documented in the README.md
Title of the PR starts with chart name (e.g. [stable/mychartname])

…v1' - Mandatory for K8s 1.16 Signed-off-by: Jacky Jiang <[email protected]>

k8s-ci-robot · 2020-02-19T23:56:48Z

Hi @t83714. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

t83714 · 2020-02-19T23:59:40Z

/assign @scottrigby

…e labels of the .spec.template. This fix the issue with creating DaemonSet through new `apps/v1` api. Signed-off-by: Jacky Jiang <[email protected]>

zanhsieh · 2020-02-27T20:01:18Z

/ok-to-test

stale · 2020-03-28T20:50:35Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

t83714 · 2020-03-29T05:44:16Z

@scottrigby
Could you have a look at this PR when you got a chance?
Thanks a lot!

stale · 2020-04-28T07:42:23Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

t83714 · 2020-04-28T11:29:55Z

Hi @zanhsieh
Any chance you could help to have a look at this one?
Thanks a lot!

zanhsieh · 2020-04-29T15:44:29Z

@lachie83
@prydonius
@sameersbn
@viglesiasce
@unguiculus
@scottrigby
@mattfarina
@davidkarlsen
@paulczar
@cpanato
@jlegrone
@maorfr
Could you guys LGTM this PR please? Thank you.

stale · 2020-05-30T06:32:00Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

t83714 · 2020-05-30T10:03:43Z

@maorfr could you please help to lgtm this PR? Thanks

t83714 · 2020-05-30T10:05:33Z

/assign @maorfr

davidkarlsen · 2020-06-02T12:08:34Z

/lgtm

k8s-ci-robot · 2020-06-02T12:08:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, t83714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [davidkarlsen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…v1' - Mandatory for K8s 1.16 (helm#20892) * [incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 Signed-off-by: Jacky Jiang <[email protected]> * As of Kubernetes 1.8, you must specify a pod selector that matches the labels of the .spec.template. This fix the issue with creating DaemonSet through new `apps/v1` api. Signed-off-by: Jacky Jiang <[email protected]>

…v1' - Mandatory for K8s 1.16 (helm#20892) * [incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 Signed-off-by: Jacky Jiang <[email protected]> * As of Kubernetes 1.8, you must specify a pod selector that matches the labels of the .spec.template. This fix the issue with creating DaemonSet through new `apps/v1` api. Signed-off-by: Jacky Jiang <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>

…v1' - Mandatory for K8s 1.16 (helm#20892) * [incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 Signed-off-by: Jacky Jiang <[email protected]> * As of Kubernetes 1.8, you must specify a pod selector that matches the labels of the .spec.template. This fix the issue with creating DaemonSet through new `apps/v1` api. Signed-off-by: Jacky Jiang <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>

[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/…

8c4bfa2

…v1' - Mandatory for K8s 1.16 Signed-off-by: Jacky Jiang <[email protected]>

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2020

k8s-ci-robot requested review from cpanato and prydonius February 19, 2020 23:57

k8s-ci-robot assigned scottrigby Feb 19, 2020

As of Kubernetes 1.8, you must specify a pod selector that matches th…

6ed59a9

…e labels of the .spec.template. This fix the issue with creating DaemonSet through new `apps/v1` api. Signed-off-by: Jacky Jiang <[email protected]>

k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020

danielhelfand mentioned this pull request Mar 10, 2020

[incubator/kube-registry-proxy] Update DaemonSet from extensions/v1beta1 to apps/v1 #21366

Closed

4 tasks

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2020

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 29, 2020

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2020

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2020

k8s-ci-robot assigned maorfr May 30, 2020

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 2, 2020

k8s-ci-robot merged commit 2cea7e0 into helm:master Jun 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 #20892

[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 #20892

t83714 commented Feb 19, 2020 •

edited

Loading

k8s-ci-robot commented Feb 19, 2020

t83714 commented Feb 19, 2020

zanhsieh commented Feb 27, 2020

stale bot commented Mar 28, 2020

t83714 commented Mar 29, 2020

stale bot commented Apr 28, 2020

t83714 commented Apr 28, 2020

zanhsieh commented Apr 29, 2020

stale bot commented May 30, 2020

t83714 commented May 30, 2020

t83714 commented May 30, 2020

davidkarlsen commented Jun 2, 2020

k8s-ci-robot commented Jun 2, 2020

[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 #20892

[incubator/kube-registry-proxy] Update DaemonSet apiVersion to 'apps/v1' - Mandatory for K8s 1.16 #20892

Conversation

t83714 commented Feb 19, 2020 • edited Loading

What this PR does / why we need it:

Checklist

k8s-ci-robot commented Feb 19, 2020

t83714 commented Feb 19, 2020

zanhsieh commented Feb 27, 2020

stale bot commented Mar 28, 2020

t83714 commented Mar 29, 2020

stale bot commented Apr 28, 2020

t83714 commented Apr 28, 2020

zanhsieh commented Apr 29, 2020

stale bot commented May 30, 2020

t83714 commented May 30, 2020

t83714 commented May 30, 2020

davidkarlsen commented Jun 2, 2020

k8s-ci-robot commented Jun 2, 2020

t83714 commented Feb 19, 2020 •

edited

Loading