Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to DuckDB v1.0.0 #2

Closed
wants to merge 4 commits into from
Closed

Backport to DuckDB v1.0.0 #2

wants to merge 4 commits into from

Conversation

lmangani
Copy link
Collaborator

@lmangani lmangani commented Jul 8, 2024

Thanks @carlopi for the guidance and assistance 🦆

@carlopi
Copy link

carlopi commented Jul 8, 2024

Error is connected to conversation at https://github.com/lmangani/duckdb-extension-clickhouse-sql/issues, where this fix works only when building vs 1.0.0. I can figure it out the proper version of this and send a PR, or a workaround is pointing in .github/workflows/MainDistributionPipeline.yml to have duckdb_version as 1.0.0.

Copy link

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this one?

.github/workflows/MainDistributionPipeline.yml Outdated Show resolved Hide resolved
.github/workflows/MainDistributionPipeline.yml Outdated Show resolved Hide resolved
@lmangani
Copy link
Collaborator Author

lmangani commented Jul 8, 2024

Maybe this one?

Thanks for keeping an eye on my rookie mistakes 😉

@lmangani
Copy link
Collaborator Author

lmangani commented Jul 8, 2024

well... not going as smooth as I was hoping this morning :) any suggestion or perhaps a little PR to help us out of this spin?

@carlopi
Copy link

carlopi commented Jul 8, 2024

I will send a PR later / tomorrow

@carlopi
Copy link

carlopi commented Jul 9, 2024

The problem in this PR has been fixed in the extension-ci-tools repository, in this duckdb/extension-ci-tools#44.

Possibly closing and reopening the PR is the easiest way to re-trigger CI while having it point to the new workflow (just restarting might not be enough).

I think that if you retrigger it should work now correctly.

I tested this on my fork on the similarly shaped https://github.com/Alex-Monahan/sql-only-duckdb-extension/pulls repo.

@lmangani lmangani closed this Jul 9, 2024
@lmangani lmangani reopened this Jul 9, 2024
@carlopi
Copy link

carlopi commented Jul 9, 2024

I need to look at this then, back in a few minutes.

@carlopi carlopi mentioned this pull request Jul 9, 2024
@lmangani lmangani closed this Jul 9, 2024
lmangani added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants