-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to DuckDB v1.0.0 #2
Conversation
Error is connected to conversation at https://github.com/lmangani/duckdb-extension-clickhouse-sql/issues, where this fix works only when building vs 1.0.0. I can figure it out the proper version of this and send a PR, or a workaround is pointing in .github/workflows/MainDistributionPipeline.yml to have duckdb_version as 1.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this one?
Thanks for keeping an eye on my rookie mistakes 😉 |
well... not going as smooth as I was hoping this morning :) any suggestion or perhaps a little PR to help us out of this spin? |
I will send a PR later / tomorrow |
The problem in this PR has been fixed in the extension-ci-tools repository, in this duckdb/extension-ci-tools#44. Possibly closing and reopening the PR is the easiest way to re-trigger CI while having it point to the new workflow (just restarting might not be enough). I think that if you retrigger it should work now correctly. I tested this on my fork on the similarly shaped https://github.com/Alex-Monahan/sql-only-duckdb-extension/pulls repo. |
I need to look at this then, back in a few minutes. |
Thanks @carlopi for the guidance and assistance 🦆