Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2 #3

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Backport #2 #3

merged 4 commits into from
Jul 9, 2024

Conversation

carlopi
Copy link

@carlopi carlopi commented Jul 9, 2024

Copy of #2.

There were some issue with the actions used underneath, that should now be fixed via duckdb/extension-ci-tools#46.

Thanks for the patience, I suppose this should now work (as it should also close and reopen the previous PR).
Tested on a fork at https://github.com/carlopi/duckdb-extension-clickhouse-sql/actions/runs/9853610199/job/27204552083

@carlopi
Copy link
Author

carlopi commented Jul 9, 2024

Either this or #2 will fix #1.

@lmangani, thanks for iterating on this, we uncovered a couple of problems in our setup.

@lmangani
Copy link
Collaborator

lmangani commented Jul 9, 2024

Thanks @carlopi for taking the time to assist!
The PR action both worked AND failed 😆 trying to understand the discrepancy

@lmangani lmangani closed this Jul 9, 2024
@lmangani lmangani reopened this Jul 9, 2024
@lmangani
Copy link
Collaborator

lmangani commented Jul 9, 2024

I can't understand - Since actions succeed I guess we can merge this PR and deal with the results directly in the main branch

@lmangani lmangani merged commit e3024a7 into quackscience:main Jul 9, 2024
71 of 80 checks passed
@carlopi
Copy link
Author

carlopi commented Jul 9, 2024

Magic of GitHub, I think this is good to merge, I think the other failures where connected at the original commit, since GitHub can't see there is some hidden state where now the proper action is run.

Thanks for bearing with this / experimenting on this.

@lmangani
Copy link
Collaborator

lmangani commented Jul 9, 2024

I really appreciate the help @carlopi! Next I need to learn how to submit this to the community repo!
Is there an action to support that workflow or it just needs a pointer? In which case... also need to learn where builds need to be

@carlopi
Copy link
Author

carlopi commented Jul 9, 2024

This is a PR that just got merged: duckdb/community-extensions#38, you can take a look for inspiration.

Basically you need to add a description.yml file in a folder called as your extension, fields that are most relevant are: which github repository to build against AND which commit.
Plus name / description, and optionally example and extended description.

I am going to write some more proper docs.

@lmangani lmangani mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants