-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #2 #3
Backport #2 #3
Conversation
Thanks @carlopi for taking the time to assist! |
I can't understand - Since actions succeed I guess we can merge this PR and deal with the results directly in the main branch |
Magic of GitHub, I think this is good to merge, I think the other failures where connected at the original commit, since GitHub can't see there is some hidden state where now the proper action is run. Thanks for bearing with this / experimenting on this. |
I really appreciate the help @carlopi! Next I need to learn how to submit this to the community repo! |
This is a PR that just got merged: duckdb/community-extensions#38, you can take a look for inspiration. Basically you need to add a description.yml file in a folder called as your extension, fields that are most relevant are: which github repository to build against AND which commit. I am going to write some more proper docs. |
Copy of #2.
There were some issue with the actions used underneath, that should now be fixed via duckdb/extension-ci-tools#46.
Thanks for the patience, I suppose this should now work (as it should also close and reopen the previous PR).
Tested on a fork at https://github.com/carlopi/duckdb-extension-clickhouse-sql/actions/runs/9853610199/job/27204552083