Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Bangla localization files #960

Merged
merged 8 commits into from
Mar 4, 2021
Merged

Conversation

zenideas
Copy link
Contributor

@zenideas zenideas commented Feb 9, 2021

I have added Bangladeshi Bangla translations. About 100 strings not done yet though. But, I'll try to complete those soon also.

@herrvigg
Copy link
Collaborator

herrvigg commented Feb 9, 2021

Great to have some updates on the localizations!

I was thinking about this recently and it feels the settings panels have way too much text, it's too verbose and not so meaningful for translations. Some parts are technical details that should rather go to Wiki pages.

I may start to simplify this soon so perhaps wait just a little bit with the longest strings in the settings. The short ones will certainly not change so you could perhaps start with those instead.

@zenideas
Copy link
Contributor Author

zenideas commented Feb 9, 2021

I was thinking about this recently and it feels the settings panels have way too much text, it's too verbose and not so meaningful for translations. Some parts are technical details that should rather go to Wiki pages.

Nice. So large texts will not be inside codes? I am not sure how the plan is. But would like to watch.

I may start to simplify this soon so perhaps wait just a little bit with the longest strings in the settings. The short ones will certainly not change so you could perhaps start with those instead.

As I mentioned earlier. When there are more than one '%s' in a sentence, there are possiblities the sequence of them would be hard to maintain in most languages. I pasted a link from php forums in the other conversation with you. The idea to add numbered attributes like '%1s', '%2s' and so on...

@herrvigg
Copy link
Collaborator

herrvigg commented Mar 4, 2021

The reference strings for the translations may evolve but let's take your current changes.

@herrvigg herrvigg merged commit bb325cb into qtranslate:master Mar 4, 2021
qwave added a commit to qwave/qtranslate-xt that referenced this pull request Apr 14, 2021
* [Yoast] Add front filters schema and breadcumbs (qtranslate#947)

* Add Bangla localization files (qtranslate#960)

* Fix async events with jQuery3 (qtranslate#946)

* Anticipate qtx init before TinyMCEinit (qtranslate#946)

* Fix deprecated tinymce.editors (qtranslate#946)

* Remove ready handler from common (qtranslate#946)

With jQuery3, ready and load can be fired asynchronously.
We cannot assume ready is fired before load.
Since qtx is also initialized in load, no need for ready anymore.

* Refactor TinyMCE hook functions in common (qtranslate#978)

* Add permalink info for pre-path mode (qtranslate#821)

* Release 3.9.3

* Fix async qtx loading in ACF (qtranslate#988)

* Bundle Javascript with Webpack and Babel (qtranslate#990)

See instructions in the Pull Request.
Reactivate plugin or save settings to update the new paths in admin config.

* Minor webpack cleanup

* Bundle ACF with Webpack (qtranslate#992)

Regroup all sources into a single bundle dist/modules/acf.js.
Move and rename source files.

* Split common.js and rename to main (qtranslate#994)

* Split common.js into multiple core source files
* Rename common.js to main.js (entry and output)
* Rename qtranslate-admin-common PHP to qtranslate-admin-main
* qTranslateX class definition no longer exposed

* Refactor js var with ES6 const and let (qtranslate#996)

* Fix text variable not defined (qtranslate#995)

* Refactor ACF js with ES6 const let (qtranslate#997)

* Refactor jQuery wrappers with local alias (qtranslate#998)

* Disambiguate and rename js variables (qtranslate#1001)

* Define js constants for URL mode

* Remove unused js functions

* Minor js cleanup

* Complete js vars renaming

* Update dist js

* Delete deprecated functions in 3.7.3

* Fix qtx and repeaterFieldRemove in ACF JS (qtranslate#1006)

* Fix undefined use_block_editor_for_post (qtranslate#1004)

Co-authored-by: HerrVigg <[email protected]>
Co-authored-by: Lenin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants