-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qTranslateConfig.qtx is undefined #1006
Comments
This could be the same issue as #988. Do you have the possibility to try with the current version on |
I tried the current version and it gives me different errors: |
I was able to reproduce the behavior after changing the Internet connection throttling to Good 2G. Throttling |
@smiddus I've pushed a new patch to fix these 2 problems with JS. Could you please retry with this? About
@MK-RD not sure I understand the effect of throttling. How is that related to this issue? The only possibility I see would be to shuffle the asynchronous events but that was a problem in 3.9.3 not with the last changes in |
@herrvigg The changes should fix the problem! By throttling the network speed, certain problems like this can possibly be checked against. |
It works. Haven't encountered any of the previous errors yet. Thanks! |
* [Yoast] Add front filters schema and breadcumbs (qtranslate#947) * Add Bangla localization files (qtranslate#960) * Fix async events with jQuery3 (qtranslate#946) * Anticipate qtx init before TinyMCEinit (qtranslate#946) * Fix deprecated tinymce.editors (qtranslate#946) * Remove ready handler from common (qtranslate#946) With jQuery3, ready and load can be fired asynchronously. We cannot assume ready is fired before load. Since qtx is also initialized in load, no need for ready anymore. * Refactor TinyMCE hook functions in common (qtranslate#978) * Add permalink info for pre-path mode (qtranslate#821) * Release 3.9.3 * Fix async qtx loading in ACF (qtranslate#988) * Bundle Javascript with Webpack and Babel (qtranslate#990) See instructions in the Pull Request. Reactivate plugin or save settings to update the new paths in admin config. * Minor webpack cleanup * Bundle ACF with Webpack (qtranslate#992) Regroup all sources into a single bundle dist/modules/acf.js. Move and rename source files. * Split common.js and rename to main (qtranslate#994) * Split common.js into multiple core source files * Rename common.js to main.js (entry and output) * Rename qtranslate-admin-common PHP to qtranslate-admin-main * qTranslateX class definition no longer exposed * Refactor js var with ES6 const and let (qtranslate#996) * Fix text variable not defined (qtranslate#995) * Refactor ACF js with ES6 const let (qtranslate#997) * Refactor jQuery wrappers with local alias (qtranslate#998) * Disambiguate and rename js variables (qtranslate#1001) * Define js constants for URL mode * Remove unused js functions * Minor js cleanup * Complete js vars renaming * Update dist js * Delete deprecated functions in 3.7.3 * Fix qtx and repeaterFieldRemove in ACF JS (qtranslate#1006) * Fix undefined use_block_editor_for_post (qtranslate#1004) Co-authored-by: HerrVigg <[email protected]> Co-authored-by: Lenin <[email protected]>
I am getting this js error on the Appearance/Menus page:
This also blocks JS functionality such as expanding/collapsing under 'Add menu items', which means I can only add pages and not not for example custom links or a page switcher to my menus)
(Using qtranslate-xt 3.9.3, WP 5.6, ACF pro 5.9.5)
The text was updated successfully, but these errors were encountered: