231 pass and store timestamp within record #232
Conversation
# Conflicts: # CHANGELOG.md # src/record/record.rs # src/storage/core.rs # tests/tests.rs
…Now they both returns latest record + stops on the first error
src/blob/core.rs
Outdated
| @@ -262,28 +262,22 @@ where | |||
| Ok(header) | |||
| } | |||
|
|
|||
| pub(crate) async fn read_last( | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Why this allow is needed?
There was a problem hiding this comment.
read_latest is no longer used. Since this request Storage uses get_latest_entry. I thought it might be worth keeping this function for the future. What do you think?
There was a problem hiding this comment.
I think it's better to just keep in git history since it can make it harder to refactor code
There was a problem hiding this comment.
I've removed this function
There was a problem hiding this comment.
What about other dead_code allowances, they should be there?
There was a problem hiding this comment.
If we assume that the only way to read data now is by getting Entry first, then we should keep read_all_entries.
contains is questionable, but as long as it is implemented as a simple redirection to get_latest_entry, we can keep it. It is good to have such function just as a declaration, that the struct supports fast checking for existence.
There was a problem hiding this comment.
I removed all dead code
# Conflicts: # CHANGELOG.md # src/blob/core.rs # src/blob/entry.rs # src/storage/core.rs
Closes #231
Closes #229
Closes #276
Closes #241