Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide the best way of treating errors in Storage::contains and Storage::read #241

Closed
ikopylov opened this issue Jan 20, 2023 · 0 comments · Fixed by #232
Closed

Decide the best way of treating errors in Storage::contains and Storage::read #241

ikopylov opened this issue Jan 20, 2023 · 0 comments · Fixed by #232
Assignees
@ikopylov
Labels
enhancement New feature or request

Comments

@ikopylov
Copy link
Member

ikopylov commented Jan 20, 2023 •
edited
Loading

Right now, read skips errors from BLOB and continue reading from the next one. contains otherwise propagates the first error.
Looks like it is better to stop on the first error to preserve correct versioning of data. But this should be investigated
@ikopylov ikopylov added the enhancement New feature or request label Jan 20, 2023
@ikopylov ikopylov mentioned this issue Feb 8, 2023
Closed
@ikopylov ikopylov self-assigned this Feb 8, 2023
@ikopylov ikopylov changed the title Skip errors when checking blobs in Storage::contains_with Decide the best way of treating errors in Storage::contains and Storage::read May 6, 2023
@ikopylov ikopylov removed their assignment May 6, 2023
@ikopylov ikopylov mentioned this issue May 18, 2023
Merged
@ikopylov ikopylov self-assigned this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikopylov ikopylov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@ikopylov