-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LazyKet for QuantumCumulants.jl #69
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 93.34% 93.00% -0.34%
==========================================
Files 24 25 +1
Lines 3019 3104 +85
==========================================
+ Hits 2818 2887 +69
- Misses 201 217 +16 ☔ View full report in Codecov by Sentry. |
@Krastanov do you have an idea what the JET CI failures are about here? |
Not sure, they all seem to detect a variety of issues, and it will take some effort to figure out which ones are false positives. It seems most of these also get triggered on master, so presumably with some previous merge we inadvertently added them. It is also possible that with Julia 1.10 now out we simply have more issues being detectable thanks to improvements in static analysis. I would suggest just bumping the bound of "known issues" in the test file. The fact it is not zero will still be caught by |
@Krastanov okay, thanks for the quick response 👍 |
Definition of LazyKets for the numeric conversion of initial product states in QuantumCumulants.jl.