Add VIA support to Tokyo60. #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
requested changes
Mar 10, 2020
Co-Authored-By: James Young <[email protected]>
Zambumon
commented
Mar 10, 2020
noroadsleft
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Looks good to me.
As an aside, we advise against committing to your master branch, because it can make it more difficult to keep your QMK fork up to date. We advise our users to use development branches for making changes, and only using the master branch for keeping up to date.
Your Fork’s Master: Update Often, Commit Never - QMK Firmware Docs
zvecr
approved these changes
Mar 11, 2020
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Mar 11, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (107 commits) Add VIA support to Tokyo60. (qmk#8362) fix kira80 matrix mapping and add more preset layouts (qmk#8361) Rename qmk json-keymap to qmk json2c (qmk#8372) format code according to conventions [skip ci] Feature: RGBLight layers (qmk#7768) Refactor Equinox PCB revisions (qmk#8266) Replace tab indentation with spaces in is0 default keymap. (qmk#8368) Fix layer debug calls (qmk#8370) [Keymap] Added HHKB Keymap and user config (qmk#8119) Refactor rgblight_reconfig.h (qmk#7773) [Keyboard] Palette1202 (qmk#7736) [Keyboard] Helix add split common option (qmk#7718) Enable bootmagic lite for CU80 (qmk#8363) [Keymap] Update personal keymap (qmk#8354) Remove NO_UART defines from config.h for V-USB boards (qmk#8351) [Keyboard] Add Kira 80 support (qmk#8342) [Keyboard] Add PRKL30 keyboard (qmk#8319) Update Dvorak, Colemak and Workman keycode aliases (qmk#8217) Move splittest I2C (qmk#8346) [Keymap] planck layout for kifinnsson (qmk#8324) ...
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* VIA_ENABLE Tokyo60 PCB * Update config.h * Apply suggestions from code review Co-Authored-By: James Young <[email protected]> Co-authored-by: James Young <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Apr 2, 2020
* VIA_ENABLE Tokyo60 PCB * Update config.h * Apply suggestions from code review Co-Authored-By: James Young <[email protected]> Co-authored-by: James Young <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Apr 10, 2020
* VIA_ENABLE Tokyo60 PCB * Update config.h * Apply suggestions from code review Co-Authored-By: James Young <[email protected]> Co-authored-by: James Young <[email protected]>
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* VIA_ENABLE Tokyo60 PCB * Update config.h * Apply suggestions from code review Co-Authored-By: James Young <[email protected]> Co-authored-by: James Young <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* VIA_ENABLE Tokyo60 PCB * Update config.h * Apply suggestions from code review Co-Authored-By: James Young <[email protected]> Co-authored-by: James Young <[email protected]>
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* VIA_ENABLE Tokyo60 PCB * Update config.h * Apply suggestions from code review Co-Authored-By: James Young <[email protected]> Co-authored-by: James Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds VIA support for the Tokyo60 Rev.1. In addition, the Tokyo60 Readme.md has been updated.
Types of Changes
Issues Fixed or Closed by This PR
Checklist