Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HHKB Keymap and user config #8119

Merged
merged 6 commits into from
Mar 10, 2020
Merged

Added HHKB Keymap and user config #8119

merged 6 commits into from
Mar 10, 2020

Conversation

Brettm12345
Copy link
Contributor

@Brettm12345 Brettm12345 commented Feb 7, 2020 •
edited
Loading

Added my hhkb keymaps. I added a layer with a bunch of symbols that help with programming in haskell

@Brettm12345 Brettm12345 changed the title Brett Added HHKB Keymap and user config Feb 7, 2020
drashna
drashna requested changes Feb 8, 2020
View reviewed changes
users/brett/brett.h Outdated Show resolved Hide resolved
users/brett/brett.h Outdated Show resolved Hide resolved
users/brett/brett.h Outdated Show resolved Hide resolved
keyboards/hhkb/keymaps/brett/keymap.c Show resolved Hide resolved
@Brettm12345
Copy link
Contributor Author

Thank you I am very new to c

drashna
drashna requested changes Feb 8, 2020
View reviewed changes
keyboards/hhkb/keymaps/brett/config.h Outdated Show resolved Hide resolved
users/brett/brett.c Outdated Show resolved Hide resolved
users/brett/brett.h Outdated Show resolved Hide resolved
@Brettm12345
Copy link
Contributor Author

Is there a more declarative way to write out my userspace file? I'd much prefer to use a hash map or something to store the symbols. But I can't find any type info on SEND_STRING

@Brettm12345
Copy link
Contributor Author

Is there a more declarative way to write out my userspace file? I'd much prefer to use a hash map or something to store the symbols. But I can't find any type info on SEND_STRING

I think I was able to figure this out

@Brettm12345 Brettm12345 requested a review from drashna February 9, 2020 02:00
@fauxpark fauxpark added the keymap label Mar 1, 2020
@Brettm12345
Copy link
Contributor Author

Any more changes that need to be made. I've been experimenting with writing my keymap in Rust. But that's still a work in progress

fauxpark
fauxpark requested changes Mar 9, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this last thing, then LGTM

keyboards/hhkb/keymaps/brett/keymap.c Outdated Show resolved Hide resolved
@drashna drashna merged commit 483ab88 into qmk:master Mar 10, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 11, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
4f559f7 
* 'master' of https://github.com/qmk/qmk_firmware: (107 commits)
  Add VIA support to Tokyo60. (qmk#8362)
  fix kira80 matrix mapping and add more preset layouts (qmk#8361)
  Rename qmk json-keymap to qmk json2c (qmk#8372)
  format code according to conventions [skip ci]
  Feature: RGBLight layers (qmk#7768)
  Refactor Equinox PCB revisions (qmk#8266)
  Replace tab indentation with spaces in is0 default keymap. (qmk#8368)
  Fix layer debug calls (qmk#8370)
  [Keymap] Added HHKB Keymap and user config (qmk#8119)
  Refactor rgblight_reconfig.h (qmk#7773)
  [Keyboard] Palette1202 (qmk#7736)
  [Keyboard] Helix add split common option (qmk#7718)
  Enable bootmagic lite for CU80 (qmk#8363)
  [Keymap] Update personal keymap (qmk#8354)
  Remove NO_UART defines from config.h for V-USB boards (qmk#8351)
  [Keyboard] Add Kira 80 support (qmk#8342)
  [Keyboard] Add PRKL30 keyboard (qmk#8319)
  Update Dvorak, Colemak and Workman keycode aliases (qmk#8217)
  Move splittest I2C (qmk#8346)
  [Keymap] planck layout for kifinnsson (qmk#8324)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@Brettm12345 @fauxpark @c0psrul3
[Keymap] Added HHKB Keymap and user config (qmk#8119)
d784a65 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@Brettm12345 @fauxpark @sowbug
[Keymap] Added HHKB Keymap and user config (qmk#8119)
e81d5d3 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@Brettm12345 @fauxpark @HokieGeek
[Keymap] Added HHKB Keymap and user config (qmk#8119)
5f7673a 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Brettm12345 @fauxpark @kujawakk
[Keymap] Added HHKB Keymap and user config (qmk#8119)
0d7a4b3 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Brettm12345 @fauxpark @jakobaa
[Keymap] Added HHKB Keymap and user config (qmk#8119)
6bda9cf 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@Brettm12345 @fauxpark @jakeisnt
[Keymap] Added HHKB Keymap and user config (qmk#8119)
b1f05f2 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Brettm12345 @fauxpark
[Keymap] Added HHKB Keymap and user config (qmk#8119)
52ecf8d 
* Added my config

* Update my keymap

* Improve quality of brett.c

* Finish cleaning brett.c

* Remove QMK_FIRMWARE_H

* Update keyboards/hhkb/keymaps/brett/keymap.c

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brettm12345 @drashna @fauxpark