Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: TG4x #7351

Merged
merged 13 commits into from
Nov 14, 2019
Merged

New Keyboard: TG4x #7351

merged 13 commits into from
Nov 14, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Nov 13, 2019 •
edited
Loading

Description

New Keyboard TG4x. This is a very limited run, should this go into handwired?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Nov 13, 2019
View reviewed changes
keyboards/tg4x/readme.md Outdated Show resolved Hide resolved
keyboards/tg4x/readme.md Outdated Show resolved Hide resolved
keyboards/tg4x/readme.md Outdated Show resolved Hide resolved
drashna
drashna reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asfor the handwired folder, I'm not sure. It really could go in either place.

keyboards/tg4x/config.h Outdated Show resolved Hide resolved
@drashna drashna merged commit 44df087 into qmk:master Nov 14, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Nov 15, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
50b3659 
* 'master' of https://github.com/qmk/qmk_firmware: (475 commits)
  [Keyboard] kbdfans keyboards NKRO enable (qmk#7364)
  [Keyboard] fix DZ60RGB info.json (qmk#7362)
  Adding new pcb with default keymap and personal keymap (qmk#7314)
  [Core] Cleanup rules.mk for F303 keyboards (qmk#7306)
  [Docs] Japanese translation of docs/ja/newbs_best_practices.md (qmk#7337)
  Set device version from config.h for V-USB boards (qmk#7316)
  Add support for configurable polling interval and power usage o… (qmk#7336)
  capslock_led (qmk#7359)
  Move Ergodox EZ RGB Light code to custom driver  (qmk#7309)
  Fix shell.nix by pinning nixpkgs (qmk#6213)
  [Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223)
  [Docs] Encourage newbs to not download the repo as a zip (qmk#7353)
  Update debounce docs (qmk#7355)
  [Keyboard] Add TG4x (qmk#7351)
  [Keyboard] Add FLX Virgo (qmk#7352)
  format code according to conventions [skip ci]
  Adding verd layout to RSII (qmk#7296)
  Add my custom layouts for GH60, DZ60 and Minivan (qmk#7278)
  [Keyboard] Added abnt2 layout to dz60 (qmk#7340)
  [Keyboard] add Little Keyboards as a seller of helix pcbs outside of japan (qmk#7249)
  ...
@mechmerlin mechmerlin deleted the feature/tg4x branch November 27, 2019 05:48
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@mechmerlin
[Keyboard] Add TG4x (qmk#7351)
2d26342 
* initial commit

* add pins and matrix

* add an appropriate keymap

* set bootloader to caterina

* add QMK Configurator support

* turn on RGB and link time optimization

* add rgb pin

* update readme on rgb underglow info

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* setting product id to 1 to match original code
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@mechmerlin @patrl
[Keyboard] Add TG4x (qmk#7351)
ef324e5 
* initial commit

* add pins and matrix

* add an appropriate keymap

* set bootloader to caterina

* add QMK Configurator support

* turn on RGB and link time optimization

* add rgb pin

* update readme on rgb underglow info

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* setting product id to 1 to match original code
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@mechmerlin @HokieGeek
[Keyboard] Add TG4x (qmk#7351)
b755609 
* initial commit

* add pins and matrix

* add an appropriate keymap

* set bootloader to caterina

* add QMK Configurator support

* turn on RGB and link time optimization

* add rgb pin

* update readme on rgb underglow info

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/tg4x/readme.md

Co-Authored-By: fauxpark <[email protected]>

* setting product id to 1 to match original code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mechmerlin @drashna @fauxpark