Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kbdmini keyboard;dztech and kbdfans keyboards small fix #7223

Merged
merged 12 commits into from
Nov 14, 2019
Merged

add kbdmini keyboard;dztech and kbdfans keyboards small fix #7223

merged 12 commits into from
Nov 14, 2019

Conversation

moyi4681
Copy link
Contributor

No description provided.

drashna
drashna requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap all of the g_led_config stuff and rgb matrix functions in ifdefs?

keyboards/dz60/config.h Show resolved Hide resolved
fauxpark
fauxpark requested changes Oct 31, 2019
View reviewed changes
keyboards/kbdfans/kbd67/mkiirgb/mkiirgb.c Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb/dz60rgb.c Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb_ansi/dz60rgb_ansi.c Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb_wkl/dz60rgb_wkl.c Outdated Show resolved Hide resolved
keyboards/dztech/dz65rgb/dz65rgb.c Outdated Show resolved Hide resolved
@moyi4681 moyi4681 requested review from fauxpark and drashna November 1, 2019 10:59
@moyi4681
Copy link
Contributor Author

@fauxpark pls check and confirm ,thanks:)

@fauxpark
Copy link
Member

fauxpark commented Nov 10, 2019 •
edited
Loading

Why was the dz40rgb folder deleted? Does it not actually exist?
Otherwise, LGTM.

@moyi4681
Copy link
Contributor Author

Why was the dz40rgb folder deleted? Does it not actually exist?
Otherwise, LGTM.

No more exist

@moyi4681
Copy link
Contributor Author

when will this pull be merged? kbdmini need to be compile in config.qmk.fm, pls check and confirm, thank u very much:) @drashna @fauxpark

@drashna
Copy link
Member

drashna commented Nov 14, 2019

@moyi4681 To be blunt here, this is a big PR with a lot of changes. It ... isn't exactly simple to go through, due to all the changes, and the scope of the PR.

In the future, it may make things easier if you break this into distinct parts. Like breaking up the dz60rgb changes into one PR, adding the kbdmini into another PR, etc. This way, each PR is small, fairly self contained, and more importantly, easier to review. The easier it is on us, the more likely that it will be quickly reviewed and quickly merged. Especially if experience is important.

That said, looks good! And thank you for the contribution!

@drashna drashna merged commit 426c03e into qmk:master Nov 14, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Nov 15, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
50b3659 
* 'master' of https://github.com/qmk/qmk_firmware: (475 commits)
  [Keyboard] kbdfans keyboards NKRO enable (qmk#7364)
  [Keyboard] fix DZ60RGB info.json (qmk#7362)
  Adding new pcb with default keymap and personal keymap (qmk#7314)
  [Core] Cleanup rules.mk for F303 keyboards (qmk#7306)
  [Docs] Japanese translation of docs/ja/newbs_best_practices.md (qmk#7337)
  Set device version from config.h for V-USB boards (qmk#7316)
  Add support for configurable polling interval and power usage o… (qmk#7336)
  capslock_led (qmk#7359)
  Move Ergodox EZ RGB Light code to custom driver  (qmk#7309)
  Fix shell.nix by pinning nixpkgs (qmk#6213)
  [Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223)
  [Docs] Encourage newbs to not download the repo as a zip (qmk#7353)
  Update debounce docs (qmk#7355)
  [Keyboard] Add TG4x (qmk#7351)
  [Keyboard] Add FLX Virgo (qmk#7352)
  format code according to conventions [skip ci]
  Adding verd layout to RSII (qmk#7296)
  Add my custom layouts for GH60, DZ60 and Minivan (qmk#7278)
  [Keyboard] Added abnt2 layout to dz60 (qmk#7340)
  [Keyboard] add Little Keyboards as a seller of helix pcbs outside of japan (qmk#7249)
  ...
@noroadsleft noroadsleft mentioned this pull request Nov 21, 2019
Closed
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@moyi4681
[Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223)
de64da4 
* add kbdmini, dztech and kbdfans keyboards small fix

* Caps lock indicator moved from keymap

* Update dz65rgb.c

* fix error

* fix matthewrobo keymap error

* Update keyboards/kbdfans/kbd67/mkiirgb/mkiirgb.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb/dz60rgb.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb_ansi/dz60rgb_ansi.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb_wkl/dz60rgb_wkl.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz65rgb/dz65rgb.c

Co-Authored-By: fauxpark <[email protected]>

* wrap all of the g_led_config stuff and rgb matrix functions in ifdefs

wrap all of the g_led_config stuff and rgb matrix functions in ifdefs
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@moyi4681 @patrl
[Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223)
7191403 
* add kbdmini, dztech and kbdfans keyboards small fix

* Caps lock indicator moved from keymap

* Update dz65rgb.c

* fix error

* fix matthewrobo keymap error

* Update keyboards/kbdfans/kbd67/mkiirgb/mkiirgb.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb/dz60rgb.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb_ansi/dz60rgb_ansi.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb_wkl/dz60rgb_wkl.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz65rgb/dz65rgb.c

Co-Authored-By: fauxpark <[email protected]>

* wrap all of the g_led_config stuff and rgb matrix functions in ifdefs

wrap all of the g_led_config stuff and rgb matrix functions in ifdefs
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@moyi4681 @HokieGeek
[Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223)
9ffc23f 
* add kbdmini, dztech and kbdfans keyboards small fix

* Caps lock indicator moved from keymap

* Update dz65rgb.c

* fix error

* fix matthewrobo keymap error

* Update keyboards/kbdfans/kbd67/mkiirgb/mkiirgb.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb/dz60rgb.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb_ansi/dz60rgb_ansi.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz60rgb_wkl/dz60rgb_wkl.c

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/dztech/dz65rgb/dz65rgb.c

Co-Authored-By: fauxpark <[email protected]>

* wrap all of the g_led_config stuff and rgb matrix functions in ifdefs

wrap all of the g_led_config stuff and rgb matrix functions in ifdefs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moyi4681 @fauxpark @drashna