Align ARM i2c_readReg with AVR #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jul 12, 2019
drashna
requested review from
algernon,
fredizzimo,
jackhumbert,
mechmerlin,
noroadsleft,
skullydazed and
yanfali
noroadsleft
approved these changes
Jul 12, 2019
skullydazed
approved these changes
Jul 16, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jul 16, 2019
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jul 19, 2019
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Align arm i2c_readReg with avr * Align arm i2c_readReg with avr - fix cannonkeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When compiling some generic I2C code, I was getting some compile issues on ARM due to the differences in API.
i2c_readRegis fine to take a non pointer regaddr, as its only ever going to be an [in] as its the address to read. This change also matches what the docs describe the API as.I have checked all instances of
i2c_readRegand none should cause an issue.Types of Changes
Checklist