Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterise STM32 I2C pin modes and timing parameters. #5671

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Parameterise STM32 I2C pin modes and timing parameters. #5671

merged 1 commit into from
Jun 1, 2019

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 21, 2019

Description

I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.

Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc force-pushed the stm32-i2c-config branch from 9576db8 to de534cb Compare April 22, 2019 01:06
@tzarc
Copy link
Member Author

tzarc commented May 1, 2019

Hold off on any merge for the moment — on a test STM32L082 device, when using I2C3, SDA and SCL are on different GPIO ports. Will add parameters for those first.

@drashna drashna added the on hold label May 3, 2019
@tzarc tzarc force-pushed the stm32-i2c-config branch 2 times, most recently from 5f8c753 to 1137f3f Compare May 3, 2019 06:56
@tzarc
Parameterise STM32 I2C pin modes and timing parameters.
53dcfdf 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
@tzarc tzarc force-pushed the stm32-i2c-config branch from 1137f3f to 53dcfdf Compare May 3, 2019 11:01
@tzarc
Copy link
Member Author

tzarc commented May 3, 2019

Should be good to go, now.

@drashna drashna removed the on hold label May 3, 2019
@yiancar
Copy link
Contributor

yiancar commented May 30, 2019

Also looks good to me, I am the git blame...

@drashna drashna merged commit 155be34 into qmk:master Jun 1, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 5, 2019
@tzarc @drashna
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671)
0513f23 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 6, 2019
@drashna @fdidron
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671) (#71)
61d1932 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@tzarc @Timbus
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671)
12bf337 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
@zvecr zvecr mentioned this pull request Jul 12, 2019
Merged
13 tasks
@tzarc tzarc deleted the stm32-i2c-config branch November 27, 2019 05:54
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@tzarc @drashna
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671)
be6f92e 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@tzarc @JeffreyPalmer
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671)
91961dc 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@tzarc @swamp09
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671)
ba7ab78 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@tzarc @drashna
Parameterise STM32 I2C pin modes and timing parameters. (qmk#5671)
e596245 
I2C timing parameters were seemingly set up for an STM32F303 target MCU, at a specific clock speed. This commit allows specifying the timing parameters via config.h, allowing other STM32 MCUs to be targeted, potentially at different clock frequencies.
Alternate function modes for the I2C pins are now also configurable, allowing for remapping to other pins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XScorpion2 XScorpion2 XScorpion2 approved these changes

@drashna drashna drashna approved these changes

@jackhumbert jackhumbert jackhumbert approved these changes

@skullydazed skullydazed Awaiting requested review from skullydazed

@algernon algernon Awaiting requested review from algernon

@ezuk ezuk Awaiting requested review from ezuk

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

Assignees
No one assigned
Labels
core enhancement optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tzarc @yiancar @jackhumbert @drashna @XScorpion2