Mousekeys: Make KC_ACL_* behavior configurable even when the constant-speed-mode is turned off
#6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit actually do nothing. Just to make the future commits more readable.
This gets rid of copying the whole report object into a temporary object and back
- Add variable mouse_wheel_repeat - Increment mouse_repeat and mouse_wheel_repeat separately
…en MK_3_SPEED is turned off - Add two configurable constants MOUSEKEY_WHEEL_DELAY / INTERVAL - Add console support to the new variables
- Emulate the MK_3_SPEED mode with the original mode
- xd75:markus has MK_W_INTERVAL_0 360, which exceeds the limit of uint8_t
|
It looks like there are a number of merge conflicts here. Could you fix them? |
|
Resolved conflicts with b624f32 ! |
In b7b8493 I have mistakenly deleted the lib/lufa submodule. This commit reactivates the submodule.
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to configure the
KC_ACL_*behavior independently, without disabling the automatic acceleration (of the original mode).Description
I have implemented the "configurable
KC_ACL_*behavior" feature in #5043 before. But there was another nice patch, which implements a similar feature in another way (#2246). (I'm sorry that I couldn't find the PR opened, before submitting my one)KC_ACL_*behaviorWhile both of them have pros. and cons. to each other, I decided to merge them up in order to have the benefits from both these two features at the same time (instead of going separate ways further).
Types of Changes
Issues Fixed or Closed by This PR
none
Checklist
I have tried building all keymaps with
MOUSEKEY_ENABLE = yes, but some of them had failed to build. Here is the summary: https://gist.github.com/zk-phi/08a8fd23a7e6204c14d5f847ae6e0428