-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable mousekey accel #5043
Conversation
* Add macros MOUSEKEY_ACCEL*_SPEED which defines how mousekey is accelerated with KC_ACL* keycodes
* Add documentation for MOUSEKEY_ACCEL*_SPEED to the feature_mouse_keys section
Thank you, it seems much more straightforward. |
- Add MOUSEKEY_ACCEL*_WHEEL_SPEED macros
this is exciting! Definitely wanna see this one merged up. |
Looks like there's a couple conflicts here now. As soon as you get those cleaned up we can merge this. Thanks for your contribution! |
It seems that the
So I'm thinking of making another PR, which adds acceleration support to the |
This has some merge conflicts now. |
The PR #2246, which this PR conflicts with, implements a similar feature in a different way. While both two PRs have pros. and cons. to each other, I have decided to merge them up to benefit from both these two features at the same time (instead of going separate ways further). Then I have posted another PR #6062, which covers both two ways to configure mousekey acceleration. Therefore, this PR (#5043) may be closed without merging, once it's convinced that the PR #6062 is better way to go. I'm sorry for posting confusing PRs. |
Thank you for your contribution! |
Thank you for your contribution! |
Description
This PR makes it possible to customize
KC_ACL*
behavior with#define
s.I have considered to add some keycodes like
KC_ACL3
,KC_ACL4
, ... to add options, but adding#define
s seems to be more flexible and backward-compatible.Types of changes
Checklist:
I have tried
make all
, but it failed with the following error:This also happens without my changes, so I could not verify that my changes actually pass the
make all
test.