Only increment Enable status for RGB Matrix if it supports it #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested review from
algernon,
jackhumbert,
ezuk,
yanfali,
skullydazed,
fredizzimo,
noroadsleft and
mechmerlin
|
Also fixed by #5619 |
XScorpion2
approved these changes
Apr 21, 2019
|
This worked on my doro67, would like to see confirmation that this doesn't break functionality on massdrop boards. |
mechmerlin
approved these changes
Apr 22, 2019
|
@mechmerlin The Massdrop Boards are the only ones with the "extra toggle" defined. So, yeah, it shouldn't break anything. It just wasn't included in the rgb matrix code, accidently. https://github.com/qmk/qmk_firmware/blob/master/keyboards/massdrop/alt/config.h#L126 Also, #5619 addresses this, and removes the need for it altogether. But this is a smaller change. |
|
superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the RGB Matrix toggle code increments the variable. That's fine, if
RGB_MATRIX_EXTRA_TOGis defined. But it's not normally. So, on non-massdrop boards, it's creating an issue where you have to hit the toggle multiple times.This should fix the issue.
Types of Changes
Checklist