Per led (key) type rgb matrix effects - part 1 #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to update the SOL once #5418 lands |
drashna
requested review from
jackhumbert,
drashna,
ezuk,
algernon,
fredizzimo,
mechmerlin and
noroadsleft
XScorpion2
force-pushed
the
features/rgb_led_flags
branch
2 times, most recently
from
64a4008 to
6980009
Compare
|
Rebased on master for #5418 merge. Updated SOL rgb_led struct |
drashna
approved these changes
Apr 15, 2019
XScorpion2
force-pushed
the
features/rgb_led_flags
branch
from
6980009 to
9df35d4
Compare
|
Rebased on master for #5627 merge. Updated crkbd rgb_led structs |
13 tasks
XScorpion2
force-pushed
the
features/rgb_led_flags
branch
from
9df35d4 to
a5555c9
Compare
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
XScorpion2
force-pushed
the
features/rgb_led_flags
branch
from
a5555c9 to
5f056eb
Compare
|
Rebased on latest master, updated more config structs that went in while this was in queue. Re-evaluating the per led type technique used. |
akrob
pushed a commit
to akrob/qmk_firmware
that referenced
this pull request
Apr 30, 2019
* upstream/master: (779 commits) [Keyboard] Signum3.0 remove sortedcontainers (qmk#5679) Simple extended space cadet (qmk#5277) Removed forced in lining for lib8tion functions (qmk#5670) Change lib8tion library to be usable in user keymaps (qmk#5598) [Keyboard] Fixing drag-and-drop (qmk#5728) [Keyboard] Adding ortho_4x12 & planck_mit layouts for KBD4X (qmk#5729) [Keyboard] Minor fixes for Baguette (qmk#5737) Updated rgb_led struct field modifier to flags (qmk#5619) RGB Matrix: Custom effects on a kb/user level (qmk#5338) Fix Planck and Preonic builds (qmk#5658) [Keymap] dz60 keymap w/ hhkb-esque default layer (qmk#5708) [Keymap] Added compatibility for Planck rev6 (qmk#5706) [Keyboard] Satisfaction75 i2c fix and VIA layout (qmk#5726) A better new_project.sh (qmk#5191) Fix sendstring "#" producing "£" instead (qmk#5724) [Keyboard] Added WT69-A PCB (qmk#5721) [Keymap] Fix typo and function layer image for Quefrency (qmk#5719) [Keymap] Initial keyboard layout for KBD67 (qmk#5720) [Keymap] New keymap for Quefrency 65% with split backspace, RGB, media keys, mouse keys (qmk#5717) [Keyboard] Update Gergo to use newer Ergodox Matrix code (qmk#5703) ...
foosinn
pushed a commit
to foosinn/qmk_firmware
that referenced
this pull request
May 6, 2019
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 8, 2019
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part 1: Mainly the ground work renaming the rgb_led struct field modifier to flags to reflect proper contents. Exposed new api for setting the flags the effect will operate on, and updated the effects to test the led flags against the passed in flags. To validate functionality, Massdrop CTRL and ATL were updated to use the new flags for their toggle effect instead of the extra toggle define.
Part 2: Update rgb matrix to run multiple effects on different leds.
Types of Changes
Issues Fixed or Closed by This PR
Checklist