Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added cypher keyboard support #5466

Merged
merged 17 commits into from
Mar 23, 2019
Merged

added cypher keyboard support #5466

merged 17 commits into from
Mar 23, 2019

Conversation

westfoxtrot
Copy link
Contributor

Description

Added support for the cypher PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mechmerlin
mechmerlin requested changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mainly just naming convention fixes here, nothing major.

keyboards/westfoxtrot/cypher/cypher.h Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/cypher.h Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/cypher.h Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/cypher.h Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/info.json Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/readme.md Show resolved Hide resolved
keyboards/westfoxtrot/cypher/rules.mk Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Mar 23, 2019
View reviewed changes
keyboards/westfoxtrot/cypher/readme.md Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/readme.md Outdated Show resolved Hide resolved
drashna
drashna requested changes Mar 23, 2019
View reviewed changes
keyboards/westfoxtrot/cypher/config.h Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/cypher.c Outdated Show resolved Hide resolved
keyboards/westfoxtrot/cypher/rules.mk Show resolved Hide resolved
mechmerlin and others added 15 commits March 23, 2019 12:41
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/cypher.h
b5f24bd 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/cypher.h
8380561 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/cypher.h
e586cd7 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/cypher.h
17a6830 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c
5971a29 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c
9a1fd0e 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c
143ce24 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/info.json
700a797 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/info.json
049c019 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c
3afa084 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c
3346c17 
Co-Authored-By: westfoxtrot <[email protected]>
@mechmerlin @westfoxtrot
Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c
0f6ec0c 
Co-Authored-By: westfoxtrot <[email protected]>
@noroadsleft @westfoxtrot
Update keyboards/westfoxtrot/cypher/readme.md
21dcb4d 
Co-Authored-By: westfoxtrot <[email protected]>
@noroadsleft @westfoxtrot
Update keyboards/westfoxtrot/cypher/readme.md
c0eb652 
Co-Authored-By: westfoxtrot <[email protected]>
@westfoxtrot
made modifications as per requests
7e6f977
@westfoxtrot
Copy link
Contributor Author

@drashna @noroadsleft @mechmerlin all changes made as per your requests

@drashna
Copy link
Member

drashna commented Mar 23, 2019

Awesome, thanks!

@drashna drashna merged commit 2308680 into qmk:master Mar 23, 2019
@westfoxtrot westfoxtrot deleted the cypher branch March 23, 2019 18:15
noroadsleft
noroadsleft reviewed Mar 23, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too slow checking this. :(

@westfoxtrot,

The info.json file as-is right now will lead to QMK Configurator assigning keys out of order for Cypher owners who use it, and they'll end up with something like this for the default keymap.

image

Please see the corrections below.

I can go into more detail if you're interested.

keyboards/westfoxtrot/cypher/info.json Show resolved Hide resolved
keyboards/westfoxtrot/cypher/info.json Show resolved Hide resolved
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@westfoxtrot @chie4hao
[Keyboard] added cypher keyboard support (qmk#5466)
1e83136 
* added the cypher qmk configuration

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* made modifications as per requests

* removed endif from cypher.h
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 28, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
f4d26bf 
* 'master' of https://github.com/qmk/qmk_firmware: (75 commits)
  [Keyboard] E6V2 Bootmapper Client QMK port (qmk#5495)
  [Keymap] Add kwer keymap and RGB mod description to cypher (qmk#5479)
  [Keymap] added user keymap (qmk#5499)
  build size-check enhancement (qmk#5485)
  [Keyboard] Add Collide39 keyboard (qmk#5486)
  [Docs] Add udev rule for Input Club bootloaders (qmk#5494)
  [Keymap] adding keymaps (qmk#3583)
  Add 3 speed mousekey movement option (qmk#2246)
  [Keymap] add redox/rev1:fculpo keymap (qmk#5491)
  [Keymap] Update iris default (qmk#5489)
  Refactor staryu to current standards and enable support for backlight keycodes (qmk#5487)
  Fixing Ergodox_EZ rgb_led initialization
  Added songs from Nier and Nier Automata
  Document an annoyance with Grave Escape and macOS Terminal (qmk#5483)
  Bugfix for recently integrated cypher keyboard (qmk#5481)
  add keyboards/mxss/rgblight.h from e661f15:quantum/rgblight.h (qmk#5461)
  [Keymap] Planck Keymap :: rjhiglefort (qmk#5059)
  Add support for RGB LEDs wired directly to each half's controller (qmk#5392)
  [Keyboard] added cypher keyboard support (qmk#5466)
  [Keymap] Add custom Planck Light keymap (qmk#5464)
  ...
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
@westfoxtrot @zer09
[Keyboard] added cypher keyboard support (qmk#5466)
2a5cba3 
* added the cypher qmk configuration

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* made modifications as per requests

* removed endif from cypher.h
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
@westfoxtrot @danielo515
[Keyboard] added cypher keyboard support (qmk#5466)
ba560fb 
* added the cypher qmk configuration

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* made modifications as per requests

* removed endif from cypher.h
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@westfoxtrot @Timbus
[Keyboard] added cypher keyboard support (qmk#5466)
5963b17 
* added the cypher qmk configuration

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/cypher.h

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/info.json

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/keymaps/default-iso/keymap.c

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* Update keyboards/westfoxtrot/cypher/readme.md

Co-Authored-By: westfoxtrot <[email protected]>

* made modifications as per requests

* removed endif from cypher.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft requested changes

@mechmerlin mechmerlin mechmerlin requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@westfoxtrot @drashna @noroadsleft @mechmerlin