Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planck Keymap :: rjhiglefort #5059

Merged
merged 12 commits into from
Mar 24, 2019
Merged

Conversation

rjhilgefort
Copy link
Contributor

Description

Adding a keymap for Planck that I've let marinate for a while.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

none

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/planck/keymaps/rjhilgefort/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/rjhilgefort/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from mechmerlin March 24, 2019 00:01
@drashna
Copy link
Member

drashna commented Mar 24, 2019

If you could apply the requested changes above?

Namely, these changes are to keep things consistent within the QMK repo, and a bit of cleanup.

@rjhilgefort
Copy link
Contributor Author

@drashna Thanks for the prompt review and feedback. Sorry it took me so long to circle back to this PR but I think I've made all the requested changes.

@drashna
Copy link
Member

drashna commented Mar 24, 2019

Awesome, thanks!

And not a problem. Life happens!

@drashna drashna merged commit 74e05f3 into qmk:master Mar 24, 2019
@rjhilgefort
Copy link
Contributor Author

Thanks for the ✅ and merge! 🎉

chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
* copy default over as starting point

* Getting rid of dvorak and colemak for now, added a couple changes to the
keymap

* removed refs to bad layers, formatting comments

* First version of my ergodox ported layout!

* Symbols layer, media layer, updated comments

* Hyper as a single key

* Fix stuck hyper key when switching layers

* Tweak some annoying things about the layout.

- move raise left and promote alt
- remove swap keys on the last layer
- reorganize media keys so they're easier to reach and more intuitive
- fix some comment template things

* Add readme for rjhilgefort planck layout

* readme tweak

* PR feedback changes
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 28, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (75 commits)
  [Keyboard] E6V2 Bootmapper Client QMK port (qmk#5495)
  [Keymap] Add kwer keymap and RGB mod description to cypher (qmk#5479)
  [Keymap] added user keymap (qmk#5499)
  build size-check enhancement (qmk#5485)
  [Keyboard] Add Collide39 keyboard (qmk#5486)
  [Docs] Add udev rule for Input Club bootloaders (qmk#5494)
  [Keymap] adding keymaps (qmk#3583)
  Add 3 speed mousekey movement option (qmk#2246)
  [Keymap] add redox/rev1:fculpo keymap (qmk#5491)
  [Keymap] Update iris default (qmk#5489)
  Refactor staryu to current standards and enable support for backlight keycodes (qmk#5487)
  Fixing Ergodox_EZ rgb_led initialization
  Added songs from Nier and Nier Automata
  Document an annoyance with Grave Escape and macOS Terminal (qmk#5483)
  Bugfix for recently integrated cypher keyboard (qmk#5481)
  add keyboards/mxss/rgblight.h from e661f15:quantum/rgblight.h (qmk#5461)
  [Keymap] Planck Keymap :: rjhiglefort (qmk#5059)
  Add support for RGB LEDs wired directly to each half's controller (qmk#5392)
  [Keyboard] added cypher keyboard support (qmk#5466)
  [Keymap] Add custom Planck Light keymap (qmk#5464)
  ...
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
* copy default over as starting point

* Getting rid of dvorak and colemak for now, added a couple changes to the
keymap

* removed refs to bad layers, formatting comments

* First version of my ergodox ported layout!

* Symbols layer, media layer, updated comments

* Hyper as a single key

* Fix stuck hyper key when switching layers

* Tweak some annoying things about the layout.

- move raise left and promote alt
- remove swap keys on the last layer
- reorganize media keys so they're easier to reach and more intuitive
- fix some comment template things

* Add readme for rjhilgefort planck layout

* readme tweak

* PR feedback changes
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
* copy default over as starting point

* Getting rid of dvorak and colemak for now, added a couple changes to the
keymap

* removed refs to bad layers, formatting comments

* First version of my ergodox ported layout!

* Symbols layer, media layer, updated comments

* Hyper as a single key

* Fix stuck hyper key when switching layers

* Tweak some annoying things about the layout.

- move raise left and promote alt
- remove swap keys on the last layer
- reorganize media keys so they're easier to reach and more intuitive
- fix some comment template things

* Add readme for rjhilgefort planck layout

* readme tweak

* PR feedback changes
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* copy default over as starting point

* Getting rid of dvorak and colemak for now, added a couple changes to the
keymap

* removed refs to bad layers, formatting comments

* First version of my ergodox ported layout!

* Symbols layer, media layer, updated comments

* Hyper as a single key

* Fix stuck hyper key when switching layers

* Tweak some annoying things about the layout.

- move raise left and promote alt
- remove swap keys on the last layer
- reorganize media keys so they're easier to reach and more intuitive
- fix some comment template things

* Add readme for rjhilgefort planck layout

* readme tweak

* PR feedback changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants