Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MNK 65 EC #23168

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Add MNK 65 EC #23168

merged 6 commits into from
Apr 1, 2024

Conversation

Cipulot
Copy link
Contributor

@Cipulot Cipulot commented Feb 28, 2024

Description

Addition of the MNK 65 EC, the EC variant of the MNK 65.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 28, 2024
waffle87
waffle87 reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggestions on #23173

@Cipulot Cipulot mentioned this pull request Mar 14, 2024
Merged
14 tasks
@Cipulot Cipulot mentioned this pull request Mar 16, 2024
Merged
14 tasks
@drashna drashna requested a review from a team March 29, 2024 03:43
@Cipulot Cipulot mentioned this pull request Mar 29, 2024
Merged
14 tasks
@nooges nooges merged commit 5fc4e33 into qmk:master Apr 1, 2024
3 checks passed
@Cipulot Cipulot mentioned this pull request Apr 1, 2024
Merged
7 tasks
@Cipulot Cipulot deleted the add_mnk_65_ec branch April 1, 2024 21:58
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@Cipulot
Add MNK 65 EC (qmk#23168)
2d732d6
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@Cipulot @girtsf
Add MNK 65 EC (qmk#23168)
6bcf8f1
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@Cipulot @whoisjordangarcia
Add MNK 65 EC (qmk#23168)
74d0175
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Cipulot @nuess0r
Add MNK 65 EC (qmk#23168)
87e3968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@drashna drashna drashna approved these changes

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cipulot @nooges @drashna @waffle87