Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MNK 60 EC #23167

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Add MNK 60 EC #23167

merged 8 commits into from
Apr 1, 2024

Conversation

Cipulot
Copy link
Contributor

@Cipulot Cipulot commented Feb 28, 2024

Description

Addition of the MNK 60 EC, the EC variant of the MNK 60.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 28, 2024
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggestions on #23173

@Cipulot Cipulot mentioned this pull request Mar 14, 2024
14 tasks
@Cipulot Cipulot requested a review from waffle87 March 16, 2024 06:57
@Cipulot
Copy link
Contributor Author

Cipulot commented Mar 16, 2024

This PR, along with #23168 have higher priority of merge than the other ones I have open since boards are scheduled to be delivered to customers by the end of the month.

Other boards have scheduled deliveries too so the queue ideally would be cleared as soon as the 2 mentioned above are done.
Thanks 😃

@Cipulot
Copy link
Contributor Author

Cipulot commented Mar 21, 2024

Small bump again, thx 😄

@drashna drashna requested a review from a team March 29, 2024 03:43
@drashna drashna requested a review from a team March 29, 2024 04:44
@Cipulot Cipulot mentioned this pull request Mar 29, 2024
14 tasks
@nooges nooges merged commit 81b5ae9 into qmk:master Apr 1, 2024
3 checks passed
@Cipulot Cipulot mentioned this pull request Apr 1, 2024
7 tasks
@Cipulot Cipulot deleted the add_mnk_60_ec branch April 1, 2024 21:57
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
Co-authored-by: Duncan Sutherland <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
Co-authored-by: Duncan Sutherland <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Co-authored-by: Duncan Sutherland <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants