Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 5075 keyboard. #20556
base: master
Are you sure you want to change the base?
add 5075 keyboard. #20556
Changes from 15 commits
b05890c
0786de9
3769919
0abcf3c
68b7f69
b7b75e5
b262e2b
ab391ab
2664dc0
eed023c
6898594
ca9b103
dbccad4
326f3bd
40cb160
4bd5619
160f8b6
a7bed10
b705098
95772d1
b1ec5d8
a000c40
8358e39
04918b0
da18fe3
a3b9f61
c7a87e3
6a29e47
f68f58c
9b1c82e
bc576f6
e0b0e4d
55a0295
4dfa0d1
29afd70
f8ead3a
efe8178
56dd230
453ce3c
fe0642f
d949d9a
32134bd
6d21fe0
7de9d20
86eb94a
dee0e01
cb5f88f
251efbc
c7f769b
1558f52
8558e5c
c304962
de8f209
8ac4978
3bee3ea
f13e1d4
959eebb
193c25c
2324fca
c987357
1c2ae36
e35bb49
a0998e9
d24bf3b
593c0cf
ec17edd
aa79e41
19b4a1f
5465ec5
7acf7ec
fd7c8b5
1a3013a
45ad36f
d31be91
7a5711a
03d61c5
a424d57
d519e07
72edeea
e194523
945d412
addf6dc
546772d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These addresses are invalid for the 3733. What LED driver are you actually using for these boards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the addresses of LED driver, everything else is the same as 3733
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SNLED27351J @fauxpark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It looks like the register layout is quite similar, but there are some changes particularly on the function page, and it does not seem to be a pin-compatible drop-in replacement (3733 only comes in QFN-48 and eTFQP-48).
So although this may work right now, I think a new driver is probably warranted, especially if you have more boards in the pipeline with this chip.
Do these all use the SNLED2730 series?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,they all use SNLED2730 @fauxpark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've also discovered the CKLED2001 used by the Keychron boards is essentially identical as well, so it would be best to use that driver instead, and I'll work on renaming everything to SNLED in another PR.