add 5075 keyboard. #20556

jonylee1986 · 2023-04-25T07:59:21Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

adophoxia · 2023-04-25T15:38:57Z

Don't know how, but you guys forgot to specify both, the MCU and bootloader, in info.json which is causing the CI to fail. 🙂

keyboards/akko/5075/keymaps/default/keymap.c

keyboards/akko/5075/keymaps/via/keymap.c

keyboards/akko/5075/keymaps/via/rules.mk

keyboards/akko/5075/rules.mk

Co-authored-by: adophoxia <[email protected]>

adophoxia · 2023-04-26T02:15:20Z

Bit curious about this board. @jonylee1986, is the firmware from this PR for the 5075S that's already being sold on Akko's website or this for a different variant?

jonylee1986 · 2023-04-26T02:37:21Z

the firmware from this PR is prepared for the upcoming release of 5075 which on the AKKO official website,and it is a different variant supports the QMK.@adophoxia

github-actions · 2023-08-09T01:53:43Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboards/akko/5075/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

keyboards/akko/5075/5075.c

keyboards/akko/5075/info.json

Co-authored-by: mjbogusz <[email protected]>

keyboards/akko/5075/readme.md

madmalkav · 2024-06-11T10:13:14Z

keyboards/akko/5075/readme.md

+A customizable 75% encoder keyboard.
+
+* Keyboard Maintainer: [jonylee@hfd](https://github.com/jonylee1986)
+* Hardware Supported: Akko 5075


Maybe mention this code is also valid for 5075S kit to avoid confusion.

keyboards/akko/5075/config.h

tzarc · 2024-08-26T10:43:13Z

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Co-authored-by: Drashna Jaelre <[email protected]>

Imlimp · 2024-10-08T22:07:30Z

Does this work for Akko 5075B Plus @jonylee1986?

adophoxia · 2024-10-08T22:17:10Z

Does this work for Akko 5075B Plus @ jonylee1986?

It does not, @Imlimp. This is only for the 5075S VIA variant that is explicitly called that.

keyboards/akko/5075/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

fauxpark

RGB_ -> RM_ keycodes after this round of breaking changes.

fauxpark · 2024-11-22T13:10:17Z

keyboards/akko/5075/keymaps/default/keymap.c

+        _______, KC_MYCM, KC_MAIL, KC_WSCH, KC_WHOM, KC_MSEL, KC_MPLY, KC_MPRV, KC_MNXT, _______, _______, _______, _______, _______,           RGB_MOD,
+        _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_SPD, RGB_SPI, _______,           _______,
+        _______, _______,TG(WIN_W),_______, _______, _______, _______, _______, KC_INS,  _______, KC_PSCR, _______, _______, RGB_MOD,           _______,
+        _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_TOG, _______, _______,          RGB_HUI,           _______,
+        _______, _______, _______, KC_CALC, _______, _______, _______, KC_MUTE, KC_VOLD, KC_VOLU, _______,                   _______,  RGB_VAI, _______,
+        _______, GU_TOGG, _______,                   _______,                            _______, _______, _______,          RGB_SAD,  RGB_VAD, RGB_SAI),


Suggested change

_______, KC_MYCM, KC_MAIL, KC_WSCH, KC_WHOM, KC_MSEL, KC_MPLY, KC_MPRV, KC_MNXT, _______, _______, _______, _______, _______, RGB_MOD,

_______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_SPD, RGB_SPI, _______, _______,

_______, _______,TG(WIN_W),_______, _______, _______, _______, _______, KC_INS, _______, KC_PSCR, _______, _______, RGB_MOD, _______,

_______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_TOG, _______, _______, RGB_HUI, _______,

_______, _______, _______, KC_CALC, _______, _______, _______, KC_MUTE, KC_VOLD, KC_VOLU, _______, _______, RGB_VAI, _______,

_______, GU_TOGG, _______, _______, _______, _______, _______, RGB_SAD, RGB_VAD, RGB_SAI),

_______, KC_MYCM, KC_MAIL, KC_WSCH, KC_WHOM, KC_MSEL, KC_MPLY, KC_MPRV, KC_MNXT, _______, _______, _______, _______, _______, RM_NEXT,

_______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RM_SPDD, RM_SPDU, _______, _______,

_______, _______,TG(WIN_W),_______, _______, _______, _______, _______, KC_INS, _______, KC_PSCR, _______, _______, RM_NEXT, _______,

_______, _______, _______, _______, _______, _______, _______, _______, _______, RM_TOGG, _______, _______, RM_HUEU, _______,

_______, _______, _______, KC_CALC, _______, _______, _______, KC_MUTE, KC_VOLD, KC_VOLU, _______, _______, RM_VALU, _______,

_______, GU_TOGG, _______, _______, _______, _______, _______, RM_SATD, RM_VALD, RM_SATU),

fauxpark · 2024-11-22T13:11:01Z

keyboards/akko/5075/keymaps/default/keymap.c

+        _______, KC_F1,   KC_F2,   KC_F3,   KC_F4,   KC_F5,   KC_F6,   KC_F7,   KC_F8,   KC_F9,   KC_F10,  KC_F11,  KC_F12,  _______,             RGB_MOD,
+        _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_SPD, RGB_SPI, _______,           _______,
+        _______, _______,TG(MAC_W),_______, _______, _______, _______, _______, KC_INS,  _______, KC_PSCR,_______, _______,  RGB_MOD,           _______,
+        _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_TOG, _______, _______,          RGB_HUI,           _______,
+        _______, _______, _______, KC_CALC, _______, _______, _______, KC_MUTE, KC_VOLD, KC_VOLU, _______,                   _______,  RGB_VAI, _______,
+        _______, _______, _______,                   _______,                            _______, _______, _______,          RGB_SAD,  RGB_VAD, RGB_SAI),


Suggested change

_______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, _______, RGB_MOD,

_______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_SPD, RGB_SPI, _______, _______,

_______, _______,TG(MAC_W),_______, _______, _______, _______, _______, KC_INS, _______, KC_PSCR,_______, _______, RGB_MOD, _______,

_______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_TOG, _______, _______, RGB_HUI, _______,

_______, _______, _______, KC_CALC, _______, _______, _______, KC_MUTE, KC_VOLD, KC_VOLU, _______, _______, RGB_VAI, _______,

_______, _______, _______, _______, _______, _______, _______, RGB_SAD, RGB_VAD, RGB_SAI),

_______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, _______, RM_NEXT,

_______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RM_SPDD, RM_SPDU, _______, _______,

_______, _______,TG(MAC_W),_______, _______, _______, _______, _______, KC_INS, _______, KC_PSCR,_______, _______, RM_NEXT, _______,

_______, _______, _______, _______, _______, _______, _______, _______, _______, RM_TOGG, _______, _______, RM_HUEU, _______,

_______, _______, _______, KC_CALC, _______, _______, _______, KC_MUTE, KC_VOLD, KC_VOLU, _______, _______, RM_VALU, _______,

_______, _______, _______, _______, _______, _______, _______, RM_SATD, RM_VALD, RM_SATU),

fauxpark · 2024-11-22T13:11:28Z

keyboards/akko/5075/keymaps/default/keymap.c

+    [WIN_FN] = { ENCODER_CCW_CW(RGB_VAI, RGB_VAD) },
+    [MAC_B] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
+    [MAC_W] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
+    [MAC_FN] = { ENCODER_CCW_CW(RGB_VAI, RGB_VAD) }


Suggested change

[WIN_FN] = { ENCODER_CCW_CW(RGB_VAI, RGB_VAD) },

[MAC_B] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },

[MAC_W] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },

[MAC_FN] = { ENCODER_CCW_CW(RGB_VAI, RGB_VAD) }

[WIN_FN] = { ENCODER_CCW_CW(RM_VALU, RM_VALD) },

[MAC_B] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },

[MAC_W] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },

[MAC_FN] = { ENCODER_CCW_CW(RM_VALU, RM_VALD) }

evertonstz · 2024-11-26T17:14:49Z

keyboards/akko/5075/5075.c

+}
+
+void housekeeping_task_kb(void) {
+    gpio_write_pin(LED_MAC_OS_PIN, ((get_highest_layer(default_layer_state | layer_state) == 2) || (get_highest_layer(default_layer_state | layer_state) == 3)));


This is making the LED that's supposed to inform if the keyboard is on Mac or Windows have a strange behaviour: it informs we are on the default layer on Mac by turning on, but turns off if the FN key is pressed. On Windows, it turns off on default layer as expected, but will actually turn on when we press the FN key. Maybe something like this would be better:

Suggested change

gpio_write_pin(LED_MAC_OS_PIN, ((get_highest_layer(default_layer_state | layer_state) == 2) || (get_highest_layer(default_layer_state | layer_state) == 3)));

gpio_write_pin(LED_MAC_OS_PIN,

(get_highest_layer(default_layer_state | layer_state) == 3) ||

(get_highest_layer(default_layer_state | layer_state) == 4) ||

(get_highest_layer(default_layer_state | layer_state) == 5));

This will only turn the led on when any layer related to Mac is active.

jonylee1986 added 3 commits April 25, 2023 15:51

add 5075 keyboard.

b05890c

add 5075 keyboard

0786de9

update readme.md

3769919

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 25, 2023

update info.json

0abcf3c

adophoxia suggested changes Apr 25, 2023

View reviewed changes

jonylee1986 and others added 4 commits April 26, 2023 09:27

Update keyboards/akko/5075/rules.mk

68b7f69

Co-authored-by: adophoxia <[email protected]>

Update keyboards/akko/5075/keymaps/via/rules.mk

b7b75e5

Co-authored-by: adophoxia <[email protected]>

update info.json andadd keymap/default/rules.mk

b262e2b

update info.json

ab391ab

jonylee1986 requested a review from adophoxia April 26, 2023 06:26

adophoxia approved these changes Apr 26, 2023

View reviewed changes

jonylee1986 and others added 5 commits May 26, 2023 11:20

Move code to info.json,and removed redundant features

2664dc0

Update info.json

eed023c

Update keymap.c

6898594

Update keymap.c

ca9b103

Update readme.md

dbccad4

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 9, 2023

Update config.h

326f3bd

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 10, 2023

drashna approved these changes Aug 14, 2023

View reviewed changes

drashna requested a review from a team August 14, 2023 07:20

Update info.json

40cb160

ebeinges reviewed Sep 11, 2023

View reviewed changes

keyboards/akko/5075/keymaps/default/keymap.c Outdated Show resolved Hide resolved

jonylee1986 and others added 2 commits May 15, 2024 09:05

Update keyboards/akko/5075/5075.c

19b4a1f

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/akko/5075/5075.c

5465ec5

Co-authored-by: Drashna Jaelre <[email protected]>

fauxpark requested changes May 15, 2024

View reviewed changes

keyboards/akko/5075/5075.c Outdated Show resolved Hide resolved

Update 5075.c

7acf7ec

fauxpark approved these changes May 15, 2024

View reviewed changes

theRealCarneiro approved these changes May 15, 2024

View reviewed changes

mjbogusz reviewed May 18, 2024

View reviewed changes

keyboards/akko/5075/info.json Outdated Show resolved Hide resolved

Update keyboards/akko/5075/info.json

fd7c8b5

Co-authored-by: mjbogusz <[email protected]>

mjbogusz approved these changes May 23, 2024

View reviewed changes

jonylee1986 added 2 commits June 5, 2024 11:18

Delete keyboards/akko/5075/rules.mk

1a3013a

Rename info.json to keyboard.json

45ad36f

madmalkav reviewed Jun 11, 2024

View reviewed changes

keyboards/akko/5075/readme.md Outdated Show resolved Hide resolved

madmalkav reviewed Jun 11, 2024

View reviewed changes

jonylee1986 added 3 commits June 12, 2024 10:24

Update readme.md

d31be91

Update config.h

7a5711a

Update keyboard.json

03d61c5

drashna reviewed Jul 27, 2024

View reviewed changes

keyboards/akko/5075/config.h Outdated Show resolved Hide resolved

jonylee1986 and others added 2 commits August 29, 2024 16:06

Update keyboards/akko/5075/config.h

a424d57

Co-authored-by: Drashna Jaelre <[email protected]>

delete via keymap.

d519e07

jonylee1986 added 3 commits October 22, 2024 14:02

Update 5075.c

72edeea

Update 5075.c

e194523

Update 5075.c

945d412

dunk2k suggested changes Oct 22, 2024

View reviewed changes

keyboards/akko/5075/keyboard.json Outdated Show resolved Hide resolved

jonylee1986 and others added 2 commits October 26, 2024 11:04

Update keyboards/akko/5075/keyboard.json

addf6dc

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboard.json

546772d

fauxpark requested changes Nov 22, 2024

View reviewed changes

evertonstz reviewed Nov 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add 5075 keyboard. #20556

add 5075 keyboard. #20556

jonylee1986 commented Apr 25, 2023

adophoxia commented Apr 25, 2023

adophoxia commented Apr 26, 2023

jonylee1986 commented Apr 26, 2023

github-actions bot commented Aug 9, 2023

madmalkav Jun 11, 2024

tzarc commented Aug 26, 2024

Imlimp commented Oct 8, 2024

adophoxia commented Oct 8, 2024

fauxpark left a comment

fauxpark Nov 22, 2024

fauxpark Nov 22, 2024

fauxpark Nov 22, 2024

evertonstz Nov 26, 2024

-    gpio_write_pin(LED_MAC_OS_PIN, ((get_highest_layer(default_layer_state | layer_state) == 2) || (get_highest_layer(default_layer_state | layer_state) == 3)));
+        gpio_write_pin(LED_MAC_OS_PIN,
+    (get_highest_layer(default_layer_state | layer_state) == 3) ||
+    (get_highest_layer(default_layer_state | layer_state) == 4) ||
+    (get_highest_layer(default_layer_state | layer_state) == 5));

add 5075 keyboard. #20556

Are you sure you want to change the base?

add 5075 keyboard. #20556

Conversation

jonylee1986 commented Apr 25, 2023

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

adophoxia commented Apr 25, 2023

adophoxia commented Apr 26, 2023

jonylee1986 commented Apr 26, 2023

github-actions bot commented Aug 9, 2023

madmalkav Jun 11, 2024

Choose a reason for hiding this comment

tzarc commented Aug 26, 2024

Imlimp commented Oct 8, 2024

adophoxia commented Oct 8, 2024

fauxpark left a comment

Choose a reason for hiding this comment

fauxpark Nov 22, 2024

Choose a reason for hiding this comment

fauxpark Nov 22, 2024

Choose a reason for hiding this comment

fauxpark Nov 22, 2024

Choose a reason for hiding this comment

evertonstz Nov 26, 2024

Choose a reason for hiding this comment