Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adpenrose/akemipad fixes #19477

Merged
merged 1 commit into from
Jan 2, 2023
Merged

adpenrose/akemipad fixes #19477

merged 1 commit into from
Jan 2, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 2, 2023

Description

  • LED config should not only exist at keymap level
  • missing header guard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 2, 2023
@zvecr zvecr requested a review from a team January 2, 2023 19:20
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ADPenrose just a friendly ping to let you know there's an update to your board.

@ADPenrose
Copy link
Contributor

Thanks for the heads up!

@tzarc tzarc merged commit 975d64c into qmk:master Jan 2, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
barrettclark added a commit to barrettclark/qmk_firmware that referenced this pull request Mar 6, 2023
* upstream/master: (1825 commits)
  A comma was missing (qmk#19507)
  Bump anothrNick/github-tag-action from 1.56.0 to 1.57.0 (qmk#19502)
  Add SapuSeven MacroPad12 (qmk#19466)
  feat(kprepublic/bm60hsrgb_poker): update carlosala keymap (qmk#19426)
  [Keyboard] Stop LED1 from flashing on layer change (qmk#19427)
  Allow for specifying the number of symbols to output. (qmk#19497)
  Add `qmk mass-compile`, which intends to supercede `qmk multibuild` whilst providing support for filtering as per data-driven definitions. (qmk#18971)
  Bump anothrNick/github-tag-action from 1.55.0 to 1.56.0 (qmk#19494)
  Fix github URL for the atreyu maintainer. (qmk#19476)
  adpenrose/akemipad fixes (qmk#19477)
  [Keymap] Add Neo2-based keymap for Planck keyboard (qmk#19173)
  [Keyboard] Add community layout support to Piantor (qmk#19455)
  Keyboard/fix work louder micro (qmk#18968)
  Add docs to cover recent LAYOUT_all lint checks (qmk#19393)
  WSL `qmk flash firmware.bin` workaround (qmk#19434)
  CLI flashers should allow files outside qmk_firmware folder (qmk#19454)
  [Keyboard] Add Quarkeys Z60, reorganized keyboard file directory (qmk#19404)
  Add KB30 keyboard (qmk#19395)
  Atreyu rev2 (qmk#19443)
  Fixes unicode_map declaration example (qmk#19450)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants