Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unicode_map declaration example #19450

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Fixes unicode_map declaration example #19450

merged 1 commit into from
Dec 31, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2022

If the previous example was used the incorrect codepoints are produced.
Changes the order of arguments the declaration of the unicode_map

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

If the previous example was used the incorrect codepoints are produced.
Changes the order of arguments the declaration of the unicode_map
@drashna drashna requested a review from a team December 31, 2022 20:39
@zvecr zvecr merged commit 943aae8 into qmk:master Dec 31, 2022
@zvecr zvecr mentioned this pull request Dec 31, 2022
14 tasks
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jan 2, 2023
If the previous example was used the incorrect codepoints are produced.
Changes the order of arguments the declaration of the unicode_map
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
If the previous example was used the incorrect codepoints are produced.
Changes the order of arguments the declaration of the unicode_map
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
If the previous example was used the incorrect codepoints are produced.
Changes the order of arguments the declaration of the unicode_map
barrettclark added a commit to barrettclark/qmk_firmware that referenced this pull request Mar 6, 2023
* upstream/master: (1825 commits)
  A comma was missing (qmk#19507)
  Bump anothrNick/github-tag-action from 1.56.0 to 1.57.0 (qmk#19502)
  Add SapuSeven MacroPad12 (qmk#19466)
  feat(kprepublic/bm60hsrgb_poker): update carlosala keymap (qmk#19426)
  [Keyboard] Stop LED1 from flashing on layer change (qmk#19427)
  Allow for specifying the number of symbols to output. (qmk#19497)
  Add `qmk mass-compile`, which intends to supercede `qmk multibuild` whilst providing support for filtering as per data-driven definitions. (qmk#18971)
  Bump anothrNick/github-tag-action from 1.55.0 to 1.56.0 (qmk#19494)
  Fix github URL for the atreyu maintainer. (qmk#19476)
  adpenrose/akemipad fixes (qmk#19477)
  [Keymap] Add Neo2-based keymap for Planck keyboard (qmk#19173)
  [Keyboard] Add community layout support to Piantor (qmk#19455)
  Keyboard/fix work louder micro (qmk#18968)
  Add docs to cover recent LAYOUT_all lint checks (qmk#19393)
  WSL `qmk flash firmware.bin` workaround (qmk#19434)
  CLI flashers should allow files outside qmk_firmware folder (qmk#19454)
  [Keyboard] Add Quarkeys Z60, reorganized keyboard file directory (qmk#19404)
  Add KB30 keyboard (qmk#19395)
  Atreyu rev2 (qmk#19443)
  Fixes unicode_map declaration example (qmk#19450)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants