Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeb.io Sinc: Enable Split LED state #19187

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Keeb.io Sinc: Enable Split LED state #19187

merged 2 commits into from
Nov 30, 2022

Conversation

lickel
Copy link
Contributor

@lickel lickel commented Nov 28, 2022

Enable SPLIT_LED_STATE_ENABLE for Sinc Revs 1 & 2

Description

This should fix the caps-lock LED state when the keyboard is connected via the "right" half.
The keyboard pre-dates the existence of that macro; prior to that point, it apparently used to be the default.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lickel
Copy link
Contributor Author

lickel commented Nov 28, 2022

CC @nooges for visibility

@drashna drashna merged commit 3d091f4 into qmk:master Nov 30, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
Glodigit pushed a commit to Glodigit/qmk_firmware that referenced this pull request Oct 18, 2023
* upstream/master: (1776 commits)
  Fixup EFL and F4's sector selection. (qmk#19221)
  Fix `RGB_MATRIX_LED_COUNT` for aurora/corne (qmk#19222)
  [Keyboard] Fix config error for Charybdis (qmk#19219)
  [Keyboard] Add keyboard Caticorn (qmk#19138)
  Add meow48 ver.1.0 keyboard (qmk#19217)
  [Keyboard] Daskeyboard4 (qmk#18675)
  Update OLED doc (qmk#19213)
  [Keyboard] Add Litl keyboard (qmk#19000)
  [Keymap] Fixed ifohancroft Swap Hands Config (qmk#19176)
  Keeb.io Sinc: Enable Split LED state (qmk#19187)
  [Keymap] Update Miryoku (qmk#19190)
  Ignore some layout macro names from lint (qmk#19207)
  Add some community layouts to 40percentclub boards (qmk#19209)
  Add ortho_3x3 community layout (qmk#19210)
  Add missing default_ortho_5x5 keymap (qmk#19208)
  Fix bad bootmagic config (qmk#19206)
  Extend layout lint checks (qmk#19200)
  Fix headers in info.json reference (qmk#19202)
  Enable bootmagic (qmk#19191)
  [Keymap] Drashna updates for 0.19 (qmk#19175)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants