Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support keyboard Caticorn #19138

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Added support keyboard Caticorn #19138

merged 1 commit into from
Nov 30, 2022

Conversation

HorrorTroll
Copy link
Contributor

Description

Added support keyboard Caticorn

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 22, 2022
drashna
drashna approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

QMK CI failures are due to userspace/community keymap issues, not board related. default+via keymaps appear to compile fine.

@drashna drashna requested a review from a team November 30, 2022 07:25
@drashna drashna merged commit e9d5967 into qmk:master Nov 30, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@HorrorTroll @elpekenin
[Keyboard] Add keyboard Caticorn (qmk#19138)
8a05d27
@HorrorTroll HorrorTroll deleted the caticorn branch December 15, 2022 07:12
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@HorrorTroll @crembz
[Keyboard] Add keyboard Caticorn (qmk#19138)
03d3c3e
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@HorrorTroll
[Keyboard] Add keyboard Caticorn (qmk#19138)
3be27a3
@HorrorTroll HorrorTroll mentioned this pull request Feb 17, 2023
Closed
6 tasks
@HorrorTroll HorrorTroll mentioned this pull request Jul 29, 2023
Merged
7 tasks
Glodigit pushed a commit to Glodigit/qmk_firmware that referenced this pull request Oct 18, 2023
@dlip
Merge remote-tracking branch 'upstream/master' into dlip
fff3805 
* upstream/master: (1776 commits)
  Fixup EFL and F4's sector selection. (qmk#19221)
  Fix `RGB_MATRIX_LED_COUNT` for aurora/corne (qmk#19222)
  [Keyboard] Fix config error for Charybdis (qmk#19219)
  [Keyboard] Add keyboard Caticorn (qmk#19138)
  Add meow48 ver.1.0 keyboard (qmk#19217)
  [Keyboard] Daskeyboard4 (qmk#18675)
  Update OLED doc (qmk#19213)
  [Keyboard] Add Litl keyboard (qmk#19000)
  [Keymap] Fixed ifohancroft Swap Hands Config (qmk#19176)
  Keeb.io Sinc: Enable Split LED state (qmk#19187)
  [Keymap] Update Miryoku (qmk#19190)
  Ignore some layout macro names from lint (qmk#19207)
  Add some community layouts to 40percentclub boards (qmk#19209)
  Add ortho_3x3 community layout (qmk#19210)
  Add missing default_ortho_5x5 keymap (qmk#19208)
  Fix bad bootmagic config (qmk#19206)
  Extend layout lint checks (qmk#19200)
  Fix headers in info.json reference (qmk#19202)
  Enable bootmagic (qmk#19191)
  [Keymap] Drashna updates for 0.19 (qmk#19175)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HorrorTroll @drashna @fauxpark