Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new keyboard 'soda/cherish' #18057

Merged
merged 2 commits into from
Aug 17, 2022
Merged

add new keyboard 'soda/cherish' #18057

merged 2 commits into from
Aug 17, 2022

Conversation

jaaronkot
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 15, 2022
drashna
drashna requested changes Aug 15, 2022
View reviewed changes
keyboards/soda/cherish/config.h Outdated Show resolved Hide resolved
keyboards/soda/cherish/config.h Outdated Show resolved Hide resolved
keyboards/soda/cherish/info.json Show resolved Hide resolved
keyboards/soda/cherish/info.json Outdated Show resolved Hide resolved
keyboards/soda/cherish/rules.mk Outdated Show resolved Hide resolved
@jaaronkot jaaronkot mentioned this pull request Aug 16, 2022
Closed
6 tasks
@drashna drashna requested a review from a team August 16, 2022 17:47
@drashna drashna merged commit 6b78d07 into qmk:develop Aug 17, 2022
@jaaronkot jaaronkot deleted the develop branch August 17, 2022 08:27
This was referenced Sep 1, 2022
Closed
Merged
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@gezhaoyou @drashna @nolanseaton
[Keyboard] add 'soda/cherish' (qmk#18057)
34261f5 
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaaronkot @drashna @fauxpark @gezhaoyou