Update keyboard ‘soda/cherish’

Co-authored-by: Drashna Jaelre <[email protected]>
qmk · Aug 16, 2022 · e5463ee · e5463ee
1 parent 98c7999
commit e5463ee
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/keyboards/soda/cherish/config.h b/keyboards/soda/cherish/config.h
@@ -17,12 +17,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #pragma once
 
-/* USB Device descriptor parameter */
-#define VENDOR_ID       0xEB50 // AP for Cherish-75
-#define PRODUCT_ID      0xEB52 // AR for Cherish-75
-#define DEVICE_VER      0x0001 // Revision pre-Alpha
-#define MANUFACTURER    gezhaoyou
-#define PRODUCT         Cherish-75
 
 /* key matrix size */
 #define MATRIX_ROWS 6
@@ -69,7 +63,16 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define RGB_DI_PIN A13
 #ifdef RGB_DI_PIN
-#define RGBLIGHT_ANIMATIONS
+#define RGBLIGHT_EFFECT_BREATHING
+#define RGBLIGHT_EFFECT_RAINBOW_MOOD
+#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
+#define RGBLIGHT_EFFECT_SNAKE
+#define RGBLIGHT_EFFECT_KNIGHT
+#define RGBLIGHT_EFFECT_CHRISTMAS
+#define RGBLIGHT_EFFECT_STATIC_GRADIENT
+#define RGBLIGHT_EFFECT_RGB_TEST
+#define RGBLIGHT_EFFECT_ALTERNATING
+#define RGBLIGHT_EFFECT_TWINKLE
 #define RGBLED_NUM 1
 #define RGBLIGHT_HUE_STEP 8
 #define RGBLIGHT_SAT_STEP 8

diff --git a/keyboards/soda/cherish/info.json b/keyboards/soda/cherish/info.json
@@ -1,7 +1,13 @@
 {
-    "keyboard_name": "75% ANSI layout",
+    "keyboard_name": "Cherish-75",
     "url": "",
     "maintainer": "qmk",
+    "manufacturer": "gezhaoyou",
+    "usb": {
+        "vid": "0xEB50",
+        "pid": "0xEB52",
+        "device_version": "0.0.1"
+    },
     "layouts": {
         "LAYOUT_75_ansi": {
             "layout": [

diff --git a/keyboards/soda/cherish/rules.mk b/keyboards/soda/cherish/rules.mk
@@ -19,4 +19,3 @@ AUDIO_ENABLE = no           # Audio output
 
 # Enter lower-power sleep mode when on the ChibiOS idle thread
 OPT_DEFS += -DCORTEX_ENABLE_WFI_IDLE=TRUE
-VIA_ENABLE = yes
Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,4 +19,3 @@ AUDIO_ENABLE = no # Audio output

		# Enter lower-power sleep mode when on the ChibiOS idle thread
		OPT_DEFS += -DCORTEX_ENABLE_WFI_IDLE=TRUE
		VIA_ENABLE = yes