Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Make ChibiOS _wait.h independent of quantum.h #17645

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[Fix] Make ChibiOS _wait.h independent of quantum.h #17645

merged 1 commit into from
Jul 12, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 12, 2022

Description

...by including chibios_config.h directly. Otherwise drivers that don't include quantum.h directly will error out on REALTIME_COUNTER_CLOCK beeing undefined.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • e.g. the cirque trackpad driver only includes wait.h

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
Make ChibiOS _wait.h independent of quantum.h
14cdc1b 
...by including chibios_config.h directly. Otherwise drivers that don't
include quantum.h directly will error out on REALTIME_COUNTER_CLOCK
beeing undefined.
@github-actions github-actions bot added the core label Jul 12, 2022
@KarlK90 KarlK90 requested review from a team and zvecr July 12, 2022 17:15
@KarlK90 KarlK90 merged commit 45ffe42 into qmk:develop Jul 12, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
[Fix] Make ChibiOS _wait.h independent of quantum.h (qmk#17645)
fecdd8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @zvecr